netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: "David S.Miller" <davem@redhat.com>
Cc: Stephen Hemminger <shemminger@osdl.org>,
	Ben Greear <greearb@candelatech.com>,
	netdev@oss.sgi.com
Subject: [PATCH/RFC] disallow vlan devices on top of a logical bridge device
Date: Sat, 30 Aug 2003 15:04:03 +0200	[thread overview]
Message-ID: <200308301504.03241.bdschuym@pandora.be> (raw)

Hi all,

The patch below disables making vlan devices on top of bridge
devices, f.e. br0.12 would be impossible.
I'm no vlan expert, but I don't see the use for this and allowing it
will make the bridge-nf code hairy if we want to let {ip,arp}tables see
{IP,ARP} traffic that is embedded in a vlan header.
Also, situations like eth0.15 being a bridge port of br0.16 seem
unwanted (to me).
Dave, please apply, unless someone more knowledgeable (than me) about
this disagrees.

cheers,
Bart

--- linux-2.6.0-test4/net/bridge/br_if.c.old	2003-08-30 13:51:26.000000000 +0200
+++ linux-2.6.0-test4/net/bridge/br_if.c	2003-08-30 14:38:58.000000000 +0200
@@ -98,6 +98,8 @@ static struct net_bridge *new_nb(const c
 	if (!dev)
 		return NULL;
 
+	dev->features |= NETIF_F_VLAN_CHALLENGED;
+	
 	br = dev->priv;
 	br->dev = dev;
 

             reply	other threads:[~2003-08-30 13:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-30 13:04 Bart De Schuymer [this message]
2003-08-30 13:21 ` [PATCH/RFC] disallow vlan devices on top of a logical bridge device Bart De Schuymer
2003-08-30 19:46 ` Ben Greear
2003-09-05 11:42   ` [VLAN] " Peter Stuge
2003-08-30 21:16 ` Krzysztof Halasa
2003-08-31  3:30 ` David S. Miller
2003-09-02 15:28   ` Stephen Hemminger
2003-09-02 17:32     ` Bart De Schuymer
2003-09-02 18:24       ` Krzysztof Halasa
2003-09-02 20:02         ` Bart De Schuymer
2003-09-02 21:43           ` Krzysztof Halasa
2003-09-02 23:05       ` Eran Mann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200308301504.03241.bdschuym@pandora.be \
    --to=bdschuym@pandora.be \
    --cc=davem@redhat.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).