From: "David S. Miller" <davem@redhat.com>
To: Vinay K Nallamothu <vinay-rc@naturesoft.net>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.4.22-pre1][NET] timer cleanups
Date: Sat, 30 Aug 2003 20:33:11 -0700 [thread overview]
Message-ID: <20030830203311.0b8c0807.davem@redhat.com> (raw)
In-Reply-To: <1062258097.8532.26.camel@lima.royalchallenge.com>
On Sat, 30 Aug 2003 21:11:37 +0530
Vinay K Nallamothu <vinay-rc@naturesoft.net> wrote:
> This patch does the following timer code cleanup:
>
> 1. Change del_timer/add_timer to mod_timer
> 2. Use static timer initialisation wherever applicable
I'm not accepting this. In particular, the ip6_flowlabel.c
change is a bad idea because the code remains racey. Someone
submitted a similar move to mod_timer() for ip6_flowlabel
earlier this week so see my comments there about what needs
to occur to fix the code properly.
Just blindly doing these kinds of conversions to mod_timer()
is foolhardy. You need to apply some brains to it to make
sure you really are getting rid of whatever potential races
exist in the code. And in the ip6_flowlabel.c case things are
as buggy as they were before.
next prev parent reply other threads:[~2003-08-31 3:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-30 15:41 [PATCH 2.4.22-pre1][NET] timer cleanups Vinay K Nallamothu
2003-08-31 3:33 ` David S. Miller [this message]
2003-09-01 14:00 ` Vinay K Nallamothu
2003-09-01 14:11 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030830203311.0b8c0807.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=vinay-rc@naturesoft.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).