netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ipx - set socket owner field
@ 2003-08-29 18:37 Stephen Hemminger
  2003-08-31  2:06 ` David S. Miller
  2003-08-31 17:35 ` Arnaldo Carvalho de Melo
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2003-08-29 18:37 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo, David S. Miller; +Cc: netdev

All sockets created by a protocol need to have owner field set
to prevent problems with orphaned sockets during module unload.

Patch for 2.6.0-test4

diff -Nru a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c
--- a/net/ipx/af_ipx.c	Fri Aug 29 11:20:48 2003
+++ b/net/ipx/af_ipx.c	Fri Aug 29 11:20:48 2003
@@ -1365,6 +1365,7 @@
 			atomic_read(&ipx_sock_nr));
 #endif
 	sock_init_data(sock, sk);
+	sk_set_owner(sk, THIS_MODULE);
 	sk->sk_no_check = 1;		/* Checksum off by default */
 	rc = 0;
 out:

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ipx - set socket owner field
  2003-08-29 18:37 [PATCH] ipx - set socket owner field Stephen Hemminger
@ 2003-08-31  2:06 ` David S. Miller
  2003-08-31 17:35 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2003-08-31  2:06 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: acme, netdev

On Fri, 29 Aug 2003 11:37:04 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:

> All sockets created by a protocol need to have owner field set
> to prevent problems with orphaned sockets during module unload.

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ipx - set socket owner field
  2003-08-29 18:37 [PATCH] ipx - set socket owner field Stephen Hemminger
  2003-08-31  2:06 ` David S. Miller
@ 2003-08-31 17:35 ` Arnaldo Carvalho de Melo
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2003-08-31 17:35 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: Arnaldo Carvalho de Melo, David S. Miller, netdev

Em Fri, Aug 29, 2003 at 11:37:04AM -0700, Stephen Hemminger escreveu:
> All sockets created by a protocol need to have owner field set
> to prevent problems with orphaned sockets during module unload.
> 
> Patch for 2.6.0-test4
> 
> diff -Nru a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c
> --- a/net/ipx/af_ipx.c	Fri Aug 29 11:20:48 2003
> +++ b/net/ipx/af_ipx.c	Fri Aug 29 11:20:48 2003
> @@ -1365,6 +1365,7 @@
>  			atomic_read(&ipx_sock_nr));
>  #endif
>  	sock_init_data(sock, sk);
> +	sk_set_owner(sk, THIS_MODULE);
>  	sk->sk_no_check = 1;		/* Checksum off by default */
>  	rc = 0;
>  out:

Thanks Stephen, I'm having problems with my home network for the last week or
so, so have been pretty much unresponsive, will be looking over all this and
the appletalk test (yes, I haven't forgotten that one) as soon as possible.

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-08-31 17:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-29 18:37 [PATCH] ipx - set socket owner field Stephen Hemminger
2003-08-31  2:06 ` David S. Miller
2003-08-31 17:35 ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).