netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [bdschuym@pandora.be: Re: ipt_physdev.c alignment problems on parisc64]
@ 2003-09-03 16:20 Arnaldo Carvalho de Melo
  2003-09-04  3:05 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2003-09-03 16:20 UTC (permalink / raw)
  To: David S. Miller, Bart De Schuymer; +Cc: netfilter-devel, netdev

Bart,

	Yes, it makes ipt_pysdev.c compile on parisc, Dave, could you please
apply it? Or perhaps wait for the netfilter patches, your call.

- Arnaldo

----- Forwarded message from Bart De Schuymer <bdschuym@pandora.be> -----

Date: Tue, 2 Sep 2003 21:16:41 +0200
From: Bart De Schuymer <bdschuym@pandora.be>
Subject: Re: ipt_physdev.c alignment problems on parisc64
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
	netfilter-devel@lists.netfilter.org
Cc: Linux Networking Development Mailing List <netdev@oss.sgi.com>

On Tuesday 02 September 2003 16:30, Arnaldo Carvalho de Melo wrote:
> The 1.786.1.54 changeset (i.e. the initial ipt_physdev.c one 8) created

Does this fix it?

cheers,
Bart

--- linux-2.6.0-test4/include/linux/netfilter_ipv4/ipt_physdev.h.old	2003-09-02 21:11:12.000000000 +0200
+++ linux-2.6.0-test4/include/linux/netfilter_ipv4/ipt_physdev.h	2003-09-02 21:12:30.000000000 +0200
@@ -15,7 +15,7 @@
 struct ipt_physdev_info {
 	u_int8_t invert;
 	u_int8_t bitmask;
-	char physindev[IFNAMSIZ];
+	char physindev[IFNAMSIZ] __attribute__ ((aligned (__alignof__(unsigned long))));
 	char in_mask[IFNAMSIZ];
 	char physoutdev[IFNAMSIZ];
 	char out_mask[IFNAMSIZ];

----- End forwarded message -----

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [bdschuym@pandora.be: Re: ipt_physdev.c alignment problems on parisc64]
  2003-09-03 16:20 [PATCH] [bdschuym@pandora.be: Re: ipt_physdev.c alignment problems on parisc64] Arnaldo Carvalho de Melo
@ 2003-09-04  3:05 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-09-04  3:05 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo; +Cc: bdschuym, netfilter-devel, netdev

On Wed, 3 Sep 2003 13:20:23 -0300
Arnaldo Carvalho de Melo <acme@conectiva.com.br> wrote:

> 	Yes, it makes ipt_pysdev.c compile on parisc, Dave, could you please
> apply it? Or perhaps wait for the netfilter patches, your call.

As I mentioned in another email, this patch can't be used, it
breaks in mixed 32/64 bit environments.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-09-04  3:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-03 16:20 [PATCH] [bdschuym@pandora.be: Re: ipt_physdev.c alignment problems on parisc64] Arnaldo Carvalho de Melo
2003-09-04  3:05 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).