* Trivial fix for wrong error message from icmp.c (2.6.0-test4)
@ 2003-09-04 0:26 Dennis Jørgensen
2003-09-05 9:47 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Dennis Jørgensen @ 2003-09-04 0:26 UTC (permalink / raw)
To: netdev
Hello
I see this message a lot in my logs:
192.38.215.157 sent an invalid ICMP type 11, code 0 error to a
broadcast: 192.38.215.255 on eth0
but thats my own ip, the following fix makes 2.6.0-test4 report the same
ip as 2.4.20 did.
Should I post this somewhere else/to someone else, please let me know, I
couldn't find a FAQ for the list.
Regards
Dennis Jørgensen
(not on the list)
--- linux-2.6.0-test4.org/net/ipv4/icmp.c 2003-08-28
01:13:59.000000000 +0200
+++ linux-2.6.0-test4/net/ipv4/icmp.c 2003-08-28 02:12:56.000000000 +0200
@@ -661,7 +661,7 @@
printk(KERN_WARNING "%u.%u.%u.%u sent an invalid
ICMP "
"type %u, code %u "
"error to a broadcast:
%u.%u.%u.%u on %s\n",
- NIPQUAD(iph->saddr),
+ NIPQUAD(skb->nh.iph->saddr),
icmph->type, icmph->code,
NIPQUAD(iph->daddr),
skb->dev->name);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Trivial fix for wrong error message from icmp.c (2.6.0-test4)
2003-09-04 0:26 Trivial fix for wrong error message from icmp.c (2.6.0-test4) Dennis Jørgensen
@ 2003-09-05 9:47 ` David S. Miller
2003-09-06 12:30 ` Dennis Jørgensen
0 siblings, 1 reply; 4+ messages in thread
From: David S. Miller @ 2003-09-05 9:47 UTC (permalink / raw)
To: Dennis Jørgensen; +Cc: netdev
On Thu, 04 Sep 2003 02:26:42 +0200
Dennis Jørgensen <postmaster@q.nospam.kampsax.k-net.dk> wrote:
> Should I post this somewhere else/to someone else, please let me know, I
> couldn't find a FAQ for the list.
You're posting it to the correct place, but your patch does not
apply because your mail client has turned all the tabs in the
patch into spaces.
I can't apply this patch until you fix that up.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Trivial fix for wrong error message from icmp.c (2.6.0-test4)
2003-09-05 9:47 ` David S. Miller
@ 2003-09-06 12:30 ` Dennis Jørgensen
2003-09-11 23:51 ` David S. Miller
0 siblings, 1 reply; 4+ messages in thread
From: Dennis Jørgensen @ 2003-09-06 12:30 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
On Fri, 5 Sep 2003, David S. Miller wrote:
> On Thu, 04 Sep 2003 02:26:42 +0200
> Dennis Jørgensen <postmaster@q.nospam.kampsax.k-net.dk> wrote:
>
> > Should I post this somewhere else/to someone else, please let me know, I
> > couldn't find a FAQ for the list.
>
> You're posting it to the correct place, but your patch does not
> apply because your mail client has turned all the tabs in the
> patch into spaces.
That wasn't very nice of it.
> I can't apply this patch until you fix that up.
It should be better now.
Sorry for the inconvenience.
Dennis Jørgensen
--- linux-2.6.0-test4.org/net/ipv4/icmp.c 2003-08-28 01:13:59.000000000 +0200
+++ linux-2.6.0-test4/net/ipv4/icmp.c 2003-08-28 02:12:56.000000000 +0200
@@ -661,7 +661,7 @@
printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP "
"type %u, code %u "
"error to a broadcast: %u.%u.%u.%u on %s\n",
- NIPQUAD(iph->saddr),
+ NIPQUAD(skb->nh.iph->saddr),
icmph->type, icmph->code,
NIPQUAD(iph->daddr),
skb->dev->name);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Trivial fix for wrong error message from icmp.c (2.6.0-test4)
2003-09-06 12:30 ` Dennis Jørgensen
@ 2003-09-11 23:51 ` David S. Miller
0 siblings, 0 replies; 4+ messages in thread
From: David S. Miller @ 2003-09-11 23:51 UTC (permalink / raw)
To: Dennis Jørgensen; +Cc: netdev
On Sat, 6 Sep 2003 14:30:27 +0200 (CEST)
Dennis Jørgensen <q@kampsax.dtu.dk> wrote:
> On Fri, 5 Sep 2003, David S. Miller wrote:
>
> > I can't apply this patch until you fix that up.
>
> It should be better now.
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-09-11 23:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-04 0:26 Trivial fix for wrong error message from icmp.c (2.6.0-test4) Dennis Jørgensen
2003-09-05 9:47 ` David S. Miller
2003-09-06 12:30 ` Dennis Jørgensen
2003-09-11 23:51 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).