From: "David S. Miller" <davem@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: shemminger@osdl.org, mike.mclagan@linux.org, jgarzik@pobox.com,
netdev@oss.sgi.com
Subject: Re: [PATCH] (2/8) convert sdla to new initialization
Date: Fri, 5 Sep 2003 02:50:42 -0700 [thread overview]
Message-ID: <20030905025042.2ff7939d.davem@redhat.com> (raw)
In-Reply-To: <20030905070619.A13947@infradead.org>
On Fri, 5 Sep 2003 07:06:19 +0100
Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Sep 03, 2003 at 04:49:25PM -0700, Stephen Hemminger wrote:
> > extern int mac8390_probe(struct net_device *dev);
> > extern int mac89x0_probe(struct net_device *dev);
> > extern int mc32_probe(struct net_device *dev);
> > +#ifdef CONFIG_SDLA
> > +extern struct net_device *sdla_init(void);
> > +#endif
>
> Please don't add ifdefs around prototypes.
I fixed this all up.
prev parent reply other threads:[~2003-09-05 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-03 23:49 [PATCH] (2/8) convert sdla to new initialization Stephen Hemminger
2003-09-05 6:06 ` Christoph Hellwig
2003-09-05 9:50 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030905025042.2ff7939d.davem@redhat.com \
--to=davem@redhat.com \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=mike.mclagan@linux.org \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).