From: John Levon <levon@movementarian.org>
To: "David S. Miller" <davem@redhat.com>
Cc: chas3@users.sourceforge.net, chas@cmf.nrl.navy.mil, netdev@oss.sgi.com
Subject: Re: [PATCH][ATM] a few patches from John Levon
Date: Fri, 5 Sep 2003 10:55:39 +0100 [thread overview]
Message-ID: <20030905095539.GD38861@compsoc.man.ac.uk> (raw)
In-Reply-To: <20030905023536.68e808e7.davem@redhat.com>
On Fri, Sep 05, 2003 at 02:35:36AM -0700, David S. Miller wrote:
> All applied, although:
>
> > # [ATM]: fix atm_dev module refcount bug (from levon@movementarian.org)
>
> You included this patch twice :-)
Hmm, then I think you're missing patch 5 :
diff -Naur -X dontdiff linux-cvs/net/atm/pppoatm.c linux-fixes/net/atm/pppoatm.c
--- linux-cvs/net/atm/pppoatm.c 2003-08-29 16:57:07.000000000 +0100
+++ linux-fixes/net/atm/pppoatm.c 2003-09-04 10:51:19.000000000 +0100
@@ -341,16 +341,13 @@
return -ENOIOCTLCMD;
}
-/* the following avoids some spurious warnings from the compiler */
-#define UNUSED __attribute__((unused))
-
-static int __init UNUSED pppoatm_init(void)
+static int __init pppoatm_init(void)
{
pppoatm_ioctl_set(pppoatm_ioctl);
return 0;
}
-static void __exit UNUSED pppoatm_exit(void)
+static void __exit pppoatm_exit(void)
{
pppoatm_ioctl_set(NULL);
}
next prev parent reply other threads:[~2003-09-05 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-04 19:17 [PATCH][ATM] a few patches from John Levon chas williams
2003-09-05 9:35 ` David S. Miller
2003-09-05 9:55 ` John Levon [this message]
2003-09-05 9:55 ` David S. Miller
2003-09-05 12:40 ` chas williams
2003-09-12 0:59 ` David S. Miller
2003-09-12 2:24 ` chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030905095539.GD38861@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=chas3@users.sourceforge.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).