From: John Levon <levon@movementarian.org>
To: netdev@oss.sgi.com, shemminger@osdl.org,
linux-atm-general@lists.sourceforge.net
Subject: [PATCH] ATM - fix seqfile compile failure
Date: Fri, 5 Sep 2003 18:51:13 +0100 [thread overview]
Message-ID: <20030905175113.GA40730@compsoc.man.ac.uk> (raw)
The recent conversion to seq_file breaks CONFIG_ATM_BR2684_IPFILTER
compile.
I have absolutely no idea what the original author was attempting to
achieve with the "pos" thing, btw ... *shrug*
Entirely untested.
regards
john
diff -Naurp -X dontdiff linux-cvs/net/atm/br2684.c linux-fixes/net/atm/br2684.c
--- linux-cvs/net/atm/br2684.c 2003-09-05 07:06:15.000000000 +0100
+++ linux-fixes/net/atm/br2684.c 2003-09-05 18:55:15.000000000 +0100
@@ -732,8 +732,8 @@ static int br2684_seq_show(struct seq_fi
#ifdef CONFIG_ATM_BR2684_IPFILTER
#define b1(var, byte) ((u8 *) &brvcc->filter.var)[byte]
#define bs(var) b1(var, 0), b1(var, 1), b1(var, 2), b1(var, 3)
- if (brvcc->filter.netmask != 0 && pos-- == 0)
- return sprintf(buf, " filter=%d.%d.%d.%d/"
+ if (brvcc->filter.netmask != 0)
+ seq_printf(seq, " filter=%d.%d.%d.%d/"
"%d.%d.%d.%d\n", bs(prefix), bs(netmask));
#undef bs
#undef b1
next reply other threads:[~2003-09-05 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-05 17:51 John Levon [this message]
2003-09-05 18:14 ` [Linux-ATM-General] [PATCH] ATM - fix seqfile compile failure chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030905175113.GA40730@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).