* [PATCH] ATM - fix seqfile compile failure
@ 2003-09-05 17:51 John Levon
2003-09-05 18:14 ` [Linux-ATM-General] " chas williams
0 siblings, 1 reply; 2+ messages in thread
From: John Levon @ 2003-09-05 17:51 UTC (permalink / raw)
To: netdev, shemminger, linux-atm-general
The recent conversion to seq_file breaks CONFIG_ATM_BR2684_IPFILTER
compile.
I have absolutely no idea what the original author was attempting to
achieve with the "pos" thing, btw ... *shrug*
Entirely untested.
regards
john
diff -Naurp -X dontdiff linux-cvs/net/atm/br2684.c linux-fixes/net/atm/br2684.c
--- linux-cvs/net/atm/br2684.c 2003-09-05 07:06:15.000000000 +0100
+++ linux-fixes/net/atm/br2684.c 2003-09-05 18:55:15.000000000 +0100
@@ -732,8 +732,8 @@ static int br2684_seq_show(struct seq_fi
#ifdef CONFIG_ATM_BR2684_IPFILTER
#define b1(var, byte) ((u8 *) &brvcc->filter.var)[byte]
#define bs(var) b1(var, 0), b1(var, 1), b1(var, 2), b1(var, 3)
- if (brvcc->filter.netmask != 0 && pos-- == 0)
- return sprintf(buf, " filter=%d.%d.%d.%d/"
+ if (brvcc->filter.netmask != 0)
+ seq_printf(seq, " filter=%d.%d.%d.%d/"
"%d.%d.%d.%d\n", bs(prefix), bs(netmask));
#undef bs
#undef b1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Linux-ATM-General] [PATCH] ATM - fix seqfile compile failure
2003-09-05 17:51 [PATCH] ATM - fix seqfile compile failure John Levon
@ 2003-09-05 18:14 ` chas williams
0 siblings, 0 replies; 2+ messages in thread
From: chas williams @ 2003-09-05 18:14 UTC (permalink / raw)
To: John Levon; +Cc: netdev, shemminger, linux-atm-general
>The recent conversion to seq_file breaks CONFIG_ATM_BR2684_IPFILTER
>compile.
i sent in a patch for this already. i did a bit of testing.
>I have absolutely no idea what the original author was attempting to
>achieve with the "pos" thing, btw ... *shrug*
the "pos" stuff was used by the old proc interface.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-05 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-05 17:51 [PATCH] ATM - fix seqfile compile failure John Levon
2003-09-05 18:14 ` [Linux-ATM-General] " chas williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).