From: Stephen Hemminger <shemminger@osdl.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, <netdev@oss.sgi.com>
Subject: Re: [PATCH] sdla non-module build fix.
Date: Mon, 8 Sep 2003 10:33:24 -0700 [thread overview]
Message-ID: <20030908103324.6545cdeb.shemminger@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0309081030310.15082-100000@home.osdl.org>
On Mon, 8 Sep 2003 10:32:26 -0700 (PDT)
Linus Torvalds <torvalds@osdl.org> wrote:
>
> On Mon, 8 Sep 2003, Stephen Hemminger wrote:
> >
> > Last round of changes broke sdla build if not a module.
>
> This patch can't be right. It may fix the compile, but it looks like
> init/exit_sdla is never registered at all if it's built-in.
>
> I suspect the whole #ifdef should go away. A driver that does things
> differently depending on whether it is a module or not is generally a
> _broken_ driver.
>
> Linus
The registration for non-modular takes place via drivers/net/Space.c
calling sdla_init like it always did.
next prev parent reply other threads:[~2003-09-08 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44.0309071117290.21192-200000@home.osdl.org>
[not found] ` <3F5B7ED7.2070908@pobox.com>
2003-09-08 16:57 ` [PATCH] sdla non-module build fix Stephen Hemminger
2003-09-08 17:32 ` Linus Torvalds
2003-09-08 17:33 ` Stephen Hemminger [this message]
2003-09-08 17:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030908103324.6545cdeb.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).