From: "David S. Miller" <davem@redhat.com>
To: Michael Rozhavsky <mike@minantech.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] fix locking
Date: Mon, 8 Sep 2003 19:21:15 -0700 [thread overview]
Message-ID: <20030908192115.2f0263f3.davem@redhat.com> (raw)
In-Reply-To: <20030906002649.GA32369@server-mrozhavsky.dyndns.org>
On Fri, 5 Sep 2003 17:26:49 -0700
Michael Rozhavsky <mike@minantech.com> wrote:
> I've found two problems with locking in networking code.
The tcp_ipv4.c part is not a bug. We hold the socket lock on 'sk' and
therefore nobody else can add any entries to lopt->syn_table[]
entries.
We only need to hold the lock during the table update
because _readers_ of the hash table do not take the 'sk'
lock when do traverse the hash.
The sit.c change does look correct, and therefore I'll apply
it after some more review...
next prev parent reply other threads:[~2003-09-09 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-06 0:26 [PATCH] fix locking Michael Rozhavsky
2003-09-09 2:21 ` David S. Miller [this message]
2003-09-11 23:49 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030908192115.2f0263f3.davem@redhat.com \
--to=davem@redhat.com \
--cc=mike@minantech.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).