From: "David S. Miller" <davem@redhat.com>
To: Mitchell Blank Jr <mitch@sfgoth.com>
Cc: romieu@fr.zoreil.com, netdev@oss.sgi.com
Subject: Re: [PATCH] tiny af_packet.c cleanup
Date: Mon, 15 Sep 2003 15:56:52 -0700 [thread overview]
Message-ID: <20030915155652.3e5e89a0.davem@redhat.com> (raw)
In-Reply-To: <20030914112628.GD42531@gaz.sfgoth.com>
On Sun, 14 Sep 2003 04:26:28 -0700
Mitchell Blank Jr <mitch@sfgoth.com> wrote:
> Francois Romieu wrote:
> > See previously posted patch. Imho the non-trivial part isn't the locking
> > itself but the fact that the first test of sk->sk_filter is done _without_
> > lock.
>
> OK, that was what I thought was going on. I figured the short comment (along
> with the likely()) would explain this adequately (i.e. "we're now re-checking
> under lock so we get the authorative answer") but maybe it needs more
> explaination.
When you guys decide on a final patch let me know, the semantic
parts of Mitchell's changes look perfectly fine to me.
next prev parent reply other threads:[~2003-09-15 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-13 5:50 [PATCH] tiny af_packet.c cleanup Mitchell Blank Jr
2003-09-13 7:35 ` Francois Romieu
2003-09-13 8:02 ` Mitchell Blank Jr
2003-09-13 9:03 ` Francois Romieu
2003-09-13 20:15 ` Mitchell Blank Jr
2003-09-14 10:55 ` Francois Romieu
2003-09-14 11:26 ` Mitchell Blank Jr
2003-09-15 22:56 ` David S. Miller [this message]
2003-09-16 3:13 ` Mitchell Blank Jr
2003-09-16 5:41 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030915155652.3e5e89a0.davem@redhat.com \
--to=davem@redhat.com \
--cc=mitch@sfgoth.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).