From: Mitchell Blank Jr <mitch@sfgoth.com>
To: "David S. Miller" <davem@redhat.com>
Cc: chas williams <chas@cmf.nrl.navy.mil>,
romieu@fr.zoreil.com, netdev@oss.sgi.com
Subject: Re: [PATCH][ATM]: [clip] fix race between modifying entry->vccs and clip_start_xmit()
Date: Mon, 15 Sep 2003 15:30:48 -0700 [thread overview]
Message-ID: <20030915223048.GD92642@gaz.sfgoth.com> (raw)
In-Reply-To: <20030915150217.06b03168.davem@redhat.com>
David S. Miller wrote:
> > which is always going to be in user context. its a bit subtle but
> > there is no path to unlink_clip_vcc() that isnt in user context.
>
> Are you really totally sure that no interrupt path can release
> a VCC?
That should be the case at least for any VCC on a real interface[*].
Some ATM cards have ->close() methods that can take a while so connection
teardown has to happen with some sort of sleepable context. So if there
are cases where an interrupt causes the VCC to die they would need to be
fixed anyways.
-Mitch
[*] some protocols use psuedo-interfaces for their control connections - in
theory I guess they could be different but I don't believe there are
any cases where they are. They wouldn't affect this issue anyways though.
next prev parent reply other threads:[~2003-09-15 22:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-15 19:11 [PATCH][ATM]: [clip] fix race between modifying entry->vccs and clip_start_xmit() chas williams
2003-09-15 20:59 ` Francois Romieu
2003-09-15 21:59 ` chas williams
2003-09-15 22:02 ` David S. Miller
2003-09-15 22:30 ` Mitchell Blank Jr [this message]
2003-09-15 22:24 ` David S. Miller
2003-09-16 10:59 ` chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030915223048.GD92642@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).