netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: laforge@netfilter.org, acme@conectiva.com.br,
	netfilter-devel@lists.netfilter.org, netdev@oss.sgi.com
Subject: Re: ipt_physdev.c alignment problems on parisc64
Date: Mon, 15 Sep 2003 23:02:59 -0700	[thread overview]
Message-ID: <20030915230259.79f5a545.davem@redhat.com> (raw)
In-Reply-To: <200309160805.08171.bdschuym@pandora.be>

On Tue, 16 Sep 2003 08:05:07 +0200
Bart De Schuymer <bdschuym@pandora.be> wrote:

> Anyway, this rule about not changing structs exported to userspace truly 
> sucks, IMHO.

Welcome to the real world.

> If someone decides to compile her own kernel this person should 
> not expect every userspace tool to keep working, again IMHO.

Wouldn't it be great if you recompiled you kernel and the args
to the read() system call got rearranged?

There is simply no difference in this case.  The situation doesn't
change because the object is being passed into some netfilter module.

You can't arbitrarily change userland exported APIs at your convenience
to fix some bug.  You either have to create a new interface for the user
to use, or fix the bug without changing the API.

Will it be the end of the world if you do a byte at a time comparison,
at least as a temporary solution?

Also, another solution could be to store the object inside the kernel
using a different structure, one where you can guarentee the alignment
of these things properly.

  reply	other threads:[~2003-09-16  6:02 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-02 14:30 ipt_physdev.c alignment problems on parisc64 Arnaldo Carvalho de Melo
2003-09-02 19:16 ` Bart De Schuymer
2003-09-02 20:03   ` Arnaldo Carvalho de Melo
2003-09-04  3:04   ` David S. Miller
2003-09-05 15:31     ` Harald Welte
2003-09-09  2:14       ` David S. Miller
2003-09-13 19:59         ` Bart De Schuymer
2003-09-14  2:25           ` David S. Miller
2003-09-15 22:59           ` David S. Miller
2003-09-16  6:05             ` Bart De Schuymer
2003-09-16  6:02               ` David S. Miller [this message]
2003-09-16  9:18                 ` Henrik Nordstrom
2003-09-16 14:09                   ` Harald Welte
2003-09-17  1:16                     ` David S. Miller
2003-09-17 21:17                       ` Bart De Schuymer
2003-09-19  2:48                         ` David S. Miller
2003-09-20 11:32                           ` Bart De Schuymer
2003-09-20 16:05                             ` Arnaldo Carvalho de Melo
2003-09-22  0:53                             ` David S. Miller
2003-09-16 14:06             ` Harald Welte
2003-09-16 15:15               ` Tom Marshall
2003-09-16 15:57                 ` Bart De Schuymer
2003-09-17  1:23                   ` David S. Miller
2003-09-17  6:42                     ` Bart De Schuymer
2003-09-17  6:56                       ` David S. Miller
2003-09-12  1:40       ` jamal
2003-09-12  8:56         ` Harald Welte
2003-09-12 10:56           ` Oskar Andreasson
2003-09-12 12:56             ` jamal
2003-09-12 13:55               ` Oskar Andreasson
2003-09-12 12:54           ` jamal
2003-09-20  5:50             ` Harald Welte
2003-09-21 13:57               ` ppp ifindex WAS(Re: " jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030915230259.79f5a545.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=acme@conectiva.com.br \
    --cc=bdschuym@pandora.be \
    --cc=laforge@netfilter.org \
    --cc=netdev@oss.sgi.com \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).