From: "David S. Miller" <davem@redhat.com>
To: Mitchell Blank Jr <mitch@sfgoth.com>
Cc: shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: [PATCH] more const in skbuff
Date: Sat, 20 Sep 2003 00:42:42 -0700 [thread overview]
Message-ID: <20030920004242.2d2a029d.davem@redhat.com> (raw)
In-Reply-To: <20030918204253.GA43611@gaz.sfgoth.com>
On Thu, 18 Sep 2003 13:42:53 -0700
Mitchell Blank Jr <mitch@sfgoth.com> wrote:
> Are you sure that atomic_read() is garaunteed to take a const pointer?
> My understanding is that an arch could in theory take a spinlock (although
> none do currently)
>
> If it is garaunteed to take a const pointer then please fix the inline in
> include/asm-parisc/atomic.h or your patch will create a lot of warnings on
> that architecture.
I think it is, we decided a bit ago that spinlock based atomics
were a bad idea, and even with that the spinlock atomic_t implementations
do not take the lock in their atomic_read() implementation, they merely
wait to get a sample with the lock clear.
> Other than that this patch is a strict subset of the "small skbuff.[ch]
> tweaks" patch I posted here 2 weeks ago:
> http://oss.sgi.com/projects/netdev/archive/2003-09/msg00036.html
> Never heard from davem one way or the other on that one.
Stuff often slips through the cracks from time to time, silence
doesn't necessary mean outright rejection so resend.
I'm going to apply Stephen's patch.
prev parent reply other threads:[~2003-09-20 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-18 17:27 [PATCH] more const in skbuff Stephen Hemminger
2003-09-18 20:42 ` Mitchell Blank Jr
2003-09-20 7:42 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030920004242.2d2a029d.davem@redhat.com \
--to=davem@redhat.com \
--cc=mitch@sfgoth.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).