netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: dychen@stanford.edu, linux-kernel@vger.kernel.org,
	mc@cs.stanford.edu, netdev@oss.sgi.com
Subject: Re: [CHECKER] 32 Memory Leaks on Error Paths
Date: Sat, 20 Sep 2003 00:58:11 -0700	[thread overview]
Message-ID: <20030920005811.09f12e07.davem@redhat.com> (raw)
In-Reply-To: <20030916090748.GE27703@wohnheim.fh-wedel.de>

On Tue, 16 Sep 2003 11:07:48 +0200
Jörn Engel <joern@wohnheim.fh-wedel.de> wrote:

> Looks valid.  And since skb isn't really needed until after these
> returns, moving four lines down a bit fixes the problem.
> 
> Davem, is this correct?

Nope, now you're leaking the route instead of the SKB :-)

I'll put the correct fix in.

      reply	other threads:[~2003-09-20  7:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200309160435.h8G4ZkQM009953@elaine4.Stanford.EDU>
2003-09-16  9:07 ` [CHECKER] 32 Memory Leaks on Error Paths Jörn Engel
2003-09-20  7:58   ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030920005811.09f12e07.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=dychen@stanford.edu \
    --cc=joern@wohnheim.fh-wedel.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mc@cs.stanford.edu \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).