From: Stephen Hemminger <shemminger@osdl.org>
To: Julian Anastasov <ja@ssi.bg>, "David S. Miller" <davem@redhat.com>
Cc: Wensong Zhang <wensong@linux-vs.org>,
<lvs-users@LinuxVirtualServer.org>, <netdev@oss.sgi.com>
Subject: [PATCH] ipvs -- fix error's in list_for_each changes.
Date: Mon, 22 Sep 2003 11:22:04 -0700 [thread overview]
Message-ID: <20030922112204.225e1a98.shemminger@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0309210934460.1468-100000@u.domain.uli>
The earlier list_for_each changes introduced a couple of bugs where
lines got dropped. This restores them.
diff -Nru a/net/ipv4/ipvs/ip_vs_app.c b/net/ipv4/ipvs/ip_vs_app.c
--- a/net/ipv4/ipvs/ip_vs_app.c Mon Sep 22 11:19:05 2003
+++ b/net/ipv4/ipvs/ip_vs_app.c Mon Sep 22 11:19:05 2003
@@ -222,6 +222,8 @@
ip_vs_app_inc_release(inc);
}
+ list_del(&app->a_list);
+
up(&__ip_vs_app_mutex);
/* decrease the module use count */
diff -Nru a/net/ipv4/ipvs/ip_vs_rr.c b/net/ipv4/ipvs/ip_vs_rr.c
--- a/net/ipv4/ipvs/ip_vs_rr.c Mon Sep 22 11:19:05 2003
+++ b/net/ipv4/ipvs/ip_vs_rr.c Mon Sep 22 11:19:05 2003
@@ -73,12 +73,12 @@
continue;
}
-
dest = list_entry(q, struct ip_vs_dest, n_list);
if (!(dest->flags & IP_VS_DEST_F_OVERLOAD) &&
atomic_read(&dest->weight) > 0)
/* HIT */
goto out;
+ q = q->next;
} while (q != p);
write_unlock(&svc->sched_lock);
return NULL;
next prev parent reply other threads:[~2003-09-22 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-16 21:17 [PATCH] (3/6) ipvs -- use list_for_each_entry macro's Stephen Hemminger
2003-09-20 8:06 ` David S. Miller
2003-09-21 7:54 ` Julian Anastasov
2003-09-22 18:03 ` Stephen Hemminger
2003-09-22 22:38 ` Julian Anastasov
2003-09-22 18:22 ` Stephen Hemminger [this message]
2003-09-23 10:59 ` [PATCH] ipvs -- fix error's in list_for_each changes David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030922112204.225e1a98.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=ja@ssi.bg \
--cc=lvs-users@LinuxVirtualServer.org \
--cc=netdev@oss.sgi.com \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).