* [PATCH] 2/3 rtnetlink -- RTA_PUT unlikely.
@ 2003-09-22 23:36 Stephen Hemminger
2003-09-23 11:01 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2003-09-22 23:36 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
RTA_PUT should normally be handed enough space, so optimize
diff -Nru a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h
--- a/include/linux/rtnetlink.h Mon Sep 22 16:14:19 2003
+++ b/include/linux/rtnetlink.h Mon Sep 22 16:14:19 2003
@@ -642,8 +642,9 @@
extern void __rta_fill(struct sk_buff *skb, int attrtype, int attrlen, const void *data);
#define RTA_PUT(skb, attrtype, attrlen, data) \
-({ if (skb_tailroom(skb) < (int)RTA_SPACE(attrlen)) goto rtattr_failure; \
- __rta_fill(skb, attrtype, attrlen, data); })
+({ if (unlikely(skb_tailroom(skb) < (int)RTA_SPACE(attrlen))) \
+ goto rtattr_failure; \
+ __rta_fill(skb, attrtype, attrlen, data); })
static inline struct rtattr *
__rta_reserve(struct sk_buff *skb, int attrtype, int attrlen)
@@ -658,8 +659,9 @@
}
#define __RTA_PUT(skb, attrtype, attrlen) \
-({ if (skb_tailroom(skb) < (int)RTA_SPACE(attrlen)) goto rtattr_failure; \
- __rta_reserve(skb, attrtype, attrlen); })
+({ if (unlikely(skb_tailroom(skb) < (int)RTA_SPACE(attrlen))) \
+ goto rtattr_failure; \
+ __rta_reserve(skb, attrtype, attrlen); })
extern void rtmsg_ifinfo(int type, struct net_device *dev, unsigned change);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2/3 rtnetlink -- RTA_PUT unlikely.
2003-09-22 23:36 [PATCH] 2/3 rtnetlink -- RTA_PUT unlikely Stephen Hemminger
@ 2003-09-23 11:01 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-09-23 11:01 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On Mon, 22 Sep 2003 16:36:39 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> RTA_PUT should normally be handed enough space, so optimize
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-23 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-22 23:36 [PATCH] 2/3 rtnetlink -- RTA_PUT unlikely Stephen Hemminger
2003-09-23 11:01 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).