From: "David S. Miller" <davem@redhat.com>
To: David Brownell <david-b@pacbell.net>
Cc: hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: assertion failure at net/sched/sch_generic.c(530)
Date: Tue, 23 Sep 2003 17:42:54 -0700 [thread overview]
Message-ID: <20030923174254.03218556.davem@redhat.com> (raw)
In-Reply-To: <3F70E8EE.9070606@pacbell.net>
On Tue, 23 Sep 2003 17:44:30 -0700
David Brownell <david-b@pacbell.net> wrote:
> > Qdiscs don't get unlinked in qdisc_destroy() unless that config
> > is enabled. If you have it off, that explains the bug and the
> > fix is obvious.
>
> Well, obvious to people who know that part of the stack ... :)
Honest, it's a pretty simple bug :) Try this patch:
--- net/sched/sch_generic.c.~1~ Tue Sep 23 17:52:22 2003
+++ net/sched/sch_generic.c Tue Sep 23 17:52:28 2003
@@ -416,7 +416,6 @@
dev = qdisc->dev;
-#ifdef CONFIG_NET_SCHED
if (dev) {
struct Qdisc *q, **qp;
for (qp = &qdisc->dev->qdisc_list; (q=*qp) != NULL; qp = &q->next) {
@@ -428,7 +427,6 @@
}
#ifdef CONFIG_NET_ESTIMATOR
qdisc_kill_estimator(&qdisc->stats);
-#endif
#endif
if (ops->reset)
ops->reset(qdisc);
next prev parent reply other threads:[~2003-09-24 0:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 0:11 assertion failure at net/sched/sch_generic.c(530) David Brownell
2003-09-24 0:02 ` David S. Miller
2003-09-24 0:08 ` David S. Miller
2003-09-24 0:44 ` David Brownell
2003-09-24 0:42 ` David S. Miller [this message]
2003-09-24 15:10 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030923174254.03218556.davem@redhat.com \
--to=davem@redhat.com \
--cc=david-b@pacbell.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).