* skb_migrate() / net/atm/ipcommon.c
@ 2003-09-25 12:19 Christoph Hellwig
2003-09-25 13:17 ` chas williams
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2003-09-25 12:19 UTC (permalink / raw)
To: netdev
net/atm/ipcommon.c has a single function in it, skb_migrate which
looks pretty generic and his this comment ontop of it:
*
* This function should live in skbuff.c or skbuff.h.
*
So does this comment make sense, should it go into common code
(and kill the major ugliness in net/atm/Makefile :))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: skb_migrate() / net/atm/ipcommon.c
2003-09-25 12:19 skb_migrate() / net/atm/ipcommon.c Christoph Hellwig
@ 2003-09-25 13:17 ` chas williams
2003-09-25 16:37 ` Mitchell Blank Jr
0 siblings, 1 reply; 3+ messages in thread
From: chas williams @ 2003-09-25 13:17 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: netdev
>net/atm/ipcommon.c has a single function in it, skb_migrate which
>looks pretty generic and his this comment ontop of it:
>
> *
> * This function should live in skbuff.c or skbuff.h.
> *
>
>So does this comment make sense, should it go into common code
>(and kill the major ugliness in net/atm/Makefile :))
i am fairly sure this function will go away in the future.
its used to move an existing skb_queue to a new queue, so
the queue can be 're-processed'. it seems to me that it
might be easier to just find the current tail of the queue
and process the queue to that point instead of copying to a
new list. its on that list of things to do.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: skb_migrate() / net/atm/ipcommon.c
2003-09-25 13:17 ` chas williams
@ 2003-09-25 16:37 ` Mitchell Blank Jr
0 siblings, 0 replies; 3+ messages in thread
From: Mitchell Blank Jr @ 2003-09-25 16:37 UTC (permalink / raw)
To: chas williams; +Cc: Christoph Hellwig, netdev
chas williams wrote:
> i am fairly sure this function will go away in the future.
> its used to move an existing skb_queue to a new queue, so
> the queue can be 're-processed'. it seems to me that it
> might be easier to just find the current tail of the queue
> and process the queue to that point instead of copying to a
> new list. its on that list of things to do.
Yes, my series of "backend" patches removes ipcommon.[ch] entirely. I'll
try to send a rediff of them over the weekend if all the currently
pending ATM patches land.
-Mitch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-09-25 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-25 12:19 skb_migrate() / net/atm/ipcommon.c Christoph Hellwig
2003-09-25 13:17 ` chas williams
2003-09-25 16:37 ` Mitchell Blank Jr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).