netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Chad N. Tindel" <chad@tindel.net>
To: Shmulik Hen <shmulik.hen@intel.com>
Cc: bonding-devel@lists.sourceforge.net,
	bonding-announce@lists.sourceforge.net, netdev@oss.sgi.com,
	linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
	Jeff Garzik <jgarzik@pobox.com>, Jay Vosburgh <fubar@us.ibm.com>,
	"Noam, Amir" <amir.noam@intel.com>,
	"Mendelson, Tsippy" <tsippy.mendelson@intel.com>,
	"Noam, Marom" <noam.marom@intel.com>
Subject: Re: [Bonding-announce] [PATCH SET][bonding] cleanup
Date: Thu, 25 Sep 2003 12:47:19 -0400	[thread overview]
Message-ID: <20030925164719.GA45241@calma.pair.com> (raw)
In-Reply-To: <200309251549.59177.shmulik.hen@intel.com>

> patch set can be downloaded from:
> http://osdn.dl.sourceforge.net/sourceforge/bonding/bonding-cleanup-2.4.23-pre5.tar.bz2
> 
> This will update the following files:
> 
>         Documentation/networking/bonding.txt
>         Documentation/networking/ifenslave.c
>         drivers/net/bonding/bond_3ad.c
>         drivers/net/bonding/bond_alb.c
>         drivers/net/bonding/bond_alb.h
>         drivers/net/bonding/bonding.h
>         drivers/net/bonding/bond_main.c
>         include/linux/if_bonding.h
> 
> Description:
> patch 1 - ifenslave lite - No more IP settings to slaves, unified 
>           printing format, code re-org and broken to more functions.
> patch 2 - convert all debug prints to use the dprintk macro and 
>           consolidate format of all prints (e.g. "bonding: Error: 
>           ...").
> patch 3 - death of typedef. eliminate bonding_t/slave_t types and 
>           consolidate casting.
> patch 4 - remove dead code, old compatibility stuff and redundant 
>           checks.

I'm a bit concerned about doing some of this stuff in the 2.4 series.  That
compatibility stuff is there for a reason, and was set to be removed in
2.6.  Perhaps we shouldn't be doing stuff this drastic until 2.6 because of
the risk of breaking users.  

Chad

  parent reply	other threads:[~2003-09-25 16:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-25 12:49 [PATCH SET][bonding] cleanup Shmulik Hen
2003-09-25 16:22 ` Jay Vosburgh
2003-09-25 16:47 ` Chad N. Tindel [this message]
2003-09-25 17:11   ` [Bonding-announce] " Shmulik Hen
2003-09-25 17:33     ` Jay Vosburgh
2003-09-25 17:43       ` Shmulik Hen
2003-09-25 21:13       ` Chad N. Tindel
2003-10-05 22:28         ` Willy TARREAU
2003-10-12 15:48 ` [PATCH SET][bonding 2.4] cleanup - take 3 Shmulik Hen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030925164719.GA45241@calma.pair.com \
    --to=chad@tindel.net \
    --cc=amir.noam@intel.com \
    --cc=bonding-announce@lists.sourceforge.net \
    --cc=bonding-devel@lists.sourceforge.net \
    --cc=fubar@us.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=noam.marom@intel.com \
    --cc=shmulik.hen@intel.com \
    --cc=tsippy.mendelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).