* [PATCH] janitor: bluetooth: remove unneeded verify_area call
@ 2003-09-26 4:56 Randy.Dunlap
2003-09-26 6:02 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Randy.Dunlap @ 2003-09-26 4:56 UTC (permalink / raw)
To: netdev, davem; +Cc: maxk
Hi,
Please apply to 2.6.0-test5-current.
Thanks,
--
~Randy
From: Domen Puncer <domen@coderock.org>
linux-260-t5bk12-kj-rddunlap/net/bluetooth/hci_core.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -puN net/bluetooth/hci_core.c~net_bluetooth_hcicore_verify net/bluetooth/hci_core.c
--- linux-260-t5bk12-kj/net/bluetooth/hci_core.c~net_bluetooth_hcicore_verify 2003-09-25 16:01:20.000000000 -0700
+++ linux-260-t5bk12-kj-rddunlap/net/bluetooth/hci_core.c 2003-09-25 16:01:20.000000000 -0700
@@ -434,11 +434,11 @@ int hci_inquiry(unsigned long arg)
BT_DBG("num_rsp %d", ir.num_rsp);
- if (!verify_area(VERIFY_WRITE, ptr, sizeof(ir) +
- (sizeof(struct inquiry_info) * ir.num_rsp))) {
- copy_to_user(ptr, &ir, sizeof(ir));
+ if (!copy_to_user(ptr, &ir, sizeof(ir))) {
ptr += sizeof(ir);
- copy_to_user(ptr, buf, sizeof(struct inquiry_info) * ir.num_rsp);
+ if (copy_to_user(ptr, buf, sizeof(struct inquiry_info) *
+ ir.num_rsp))
+ err = -EFAULT;
} else
err = -EFAULT;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] janitor: bluetooth: remove unneeded verify_area call
2003-09-26 4:56 [PATCH] janitor: bluetooth: remove unneeded verify_area call Randy.Dunlap
@ 2003-09-26 6:02 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-09-26 6:02 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: netdev, maxk
On Thu, 25 Sep 2003 21:56:37 -0700
"Randy.Dunlap" <rddunlap@osdl.org> wrote:
> linux-260-t5bk12-kj-rddunlap/net/bluetooth/hci_core.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-26 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-26 4:56 [PATCH] janitor: bluetooth: remove unneeded verify_area call Randy.Dunlap
2003-09-26 6:02 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).