From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] net: rds: Don't allocate rds_sock on stack Date: Mon, 25 Aug 2014 13:33:33 +0200 Message-ID: <2003093.xT3MtFJFAa@wuerfel> References: <1408926755-12277-1-git-send-email-broonie@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Mark Brown , Chien Yen , "David S. Miller" , netdev@vger.kernel.org, rds-devel@oss.oracle.com, Mark Brown To: linaro-kernel@lists.linaro.org Return-path: Received: from mout.kundenserver.de ([212.227.126.130]:51068 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932163AbaHYLdp (ORCPT ); Mon, 25 Aug 2014 07:33:45 -0400 In-Reply-To: <1408926755-12277-1-git-send-email-broonie@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On Sunday 24 August 2014 19:32:35 Mark Brown wrote: > From: Mark Brown > > struct rds_sock is rather large ausing the following warning in an ARM > allmodconfig: > > net/rds/iw_rdma.c:200:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Fix this by dynamically allocating struct rds_sock in rds_iw_update_cm_id > instead of allocating it on the stack. > > Signed-off-by: Mark Brown > Acked-by: Arnd Bergmann