netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: chas williams <chas@cmf.nrl.navy.mil>
Cc: netdev@oss.sgi.com
Subject: Re: [RFC] add rtnl semaphore to linux-atm
Date: Wed, 1 Oct 2003 06:14:26 -0700	[thread overview]
Message-ID: <20031001061426.0b67a235.davem@redhat.com> (raw)
In-Reply-To: <200310011307.h91D7jkT004153@ginger.cmf.nrl.navy.mil>

On Wed, 01 Oct 2003 09:07:45 -0400
chas williams <chas@cmf.nrl.navy.mil> wrote:

> i had initially written it that way but remembered at one point i
> was going to use the rtnl semaphore to handle this problem.  any
> opinions on what is 'better'?

Blocking all network configuration operations (even ones not
for your subsystem) is a little bit anti-social in SMP cases.

If you take the rwlock as a reader, you only interfere with a
very minute class of network configuration code paths (those that
need to take the rwlock in question as a writer).

For example, if you use the rwlock-as-reader approach, someone doing
IPV4 routing table updates (ie. routing daemon changing a couple
thousand routes after a BGP flap) won't be perturbed while the ATM
operation is in progress.

  reply	other threads:[~2003-10-01 13:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-01 11:34 [RFC] add rtnl semaphore to linux-atm chas williams
2003-10-01 12:42 ` David S. Miller
2003-10-01 13:07   ` chas williams
2003-10-01 13:14     ` David S. Miller [this message]
2003-10-03  2:26   ` Mitchell Blank Jr
2003-10-03 13:58     ` David S. Miller
2003-10-03 21:45       ` Mitchell Blank Jr
2003-10-04  5:16         ` David S. Miller
2003-10-04  5:55           ` Mitchell Blank Jr
2003-10-04  6:56             ` Mitchell Blank Jr
2003-10-04  6:59       ` Mitchell Blank Jr
2003-10-04 12:50         ` chas williams
2003-10-04 19:42           ` Mitchell Blank Jr
2003-10-05 12:52             ` chas williams
2003-10-06  9:03               ` Mitchell Blank Jr
2003-10-06 14:46                 ` chas williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031001061426.0b67a235.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).