[RFC] Silencing needless printk in socket.c

[RFC] Silencing needless printk in socket.c

[Burton Windle]

Would anyone object to a patch that wraps the printk in
linux/net/socket.c:1897 in a 'if debug'?

This first appeared around 2.6.0-test5; the output may be helpful to a
developer, but I don't think it is needed in the normal dmesg.

dual266:/home/kernel/linux/net# dmesg  | grep NET
NET: Registered protocol family 16
NET: Registered protocol family 2
NET: Registered protocol family 1
NET: Registered protocol family 17


--
Burton Windle                           burton@fint.org
Linux: the "grim reaper of innocent orphaned children."
          from /usr/src/linux-2.4.18/init/main.c:461

Re: [RFC] Silencing needless printk in socket.c

[David S. Miller]

On Wed, 1 Oct 2003 14:41:09 -0400 (EDT)
Burton Windle <bwindle@fint.org> wrote:

> Would anyone object to a patch that wraps the printk in
> linux/net/socket.c:1897 in a 'if debug'?
> 
> This first appeared around 2.6.0-test5; the output may be helpful to a
> developer, but I don't think it is needed in the normal dmesg.

Yes it is needed, and since in the same changes that _ADDED_
this new printk I _REMOVED_ all the numerous per-protocol printks
that were printed out.

Less stuff is printed out now than before, and now this is the
only indication that a particular protocol family got registered
or unregistered successfully.

We're not removing this.  This is especially the case beause people
like you didn't complain at all when we used to get 4 or 5 lines of
printk messages for each of these protocols when they started up or
shut down.