From: Stephen Hemminger <shemminger@osdl.org>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH] skbuff more likely/unlikely
Date: Thu, 2 Oct 2003 10:24:20 -0700 [thread overview]
Message-ID: <20031002102420.6e1cece9.shemminger@osdl.org> (raw)
A couple more places where we can help by hinting the compiler
for 2.6.0-test6. If we are pulling off header, is is likely there;
and skb alloc's succeed in the normal case.
Thought I saw an earlier similar patch, but here is my take on it.
diff -Nru a/include/linux/skbuff.h b/include/linux/skbuff.h
--- a/include/linux/skbuff.h Thu Oct 2 10:01:36 2003
+++ b/include/linux/skbuff.h Thu Oct 2 10:01:36 2003
@@ -885,7 +885,7 @@
*/
static inline unsigned char *skb_pull(struct sk_buff *skb, unsigned int len)
{
- return (len > skb->len) ? NULL : __skb_pull(skb, len);
+ return unlikely(len > skb->len) ? NULL : __skb_pull(skb, len);
}
extern unsigned char *__pskb_pull_tail(struct sk_buff *skb, int delta);
@@ -901,7 +901,7 @@
static inline unsigned char *pskb_pull(struct sk_buff *skb, unsigned int len)
{
- return (len > skb->len) ? NULL : __pskb_pull(skb, len);
+ return unlikely(len > skb->len) ? NULL : __pskb_pull(skb, len);
}
static inline int pskb_may_pull(struct sk_buff *skb, unsigned int len)
@@ -1052,7 +1052,7 @@
int gfp_mask)
{
struct sk_buff *skb = alloc_skb(length + 16, gfp_mask);
- if (skb)
+ if (likely(skb))
skb_reserve(skb, 16);
return skb;
}
next reply other threads:[~2003-10-02 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-02 17:24 Stephen Hemminger [this message]
2003-10-03 2:34 ` [PATCH] skbuff more likely/unlikely Mitchell Blank Jr
2003-10-03 7:19 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031002102420.6e1cece9.shemminger@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).