From: "David S. Miller" <davem@redhat.com>
To: Mitchell Blank Jr <mitch@sfgoth.com>
Cc: chas3@users.sourceforge.net, chas@cmf.nrl.navy.mil, netdev@oss.sgi.com
Subject: Re: [RFC] add rtnl semaphore to linux-atm
Date: Fri, 3 Oct 2003 06:58:24 -0700 [thread overview]
Message-ID: <20031003065824.713627c6.davem@redhat.com> (raw)
In-Reply-To: <20031003022615.GA42593@gaz.sfgoth.com>
On Thu, 2 Oct 2003 19:26:15 -0700
Mitchell Blank Jr <mitch@sfgoth.com> wrote:
> My personal recommendations:
> * There should be a per-atm-device semaphore held across calls into the
> driver's ->open, ->close, ->change_qos and maybe a couple other things
> to serialize those operations (for the sake of keeping the drivers
> sane - there's no reason there should be multiple operations pending)
Ok, but what Chas is trying to do is move the ATM device stuff over
to a model that makes use of the existing network device infrastructure
for solving these kinds of problems.
Part of that is using the rtnl semaphore etc.
I would rather Chas use the rtnl semaphore for synchronization
than to ultra-optimize this code by using the rwlock as I had suggested
to him.
next prev parent reply other threads:[~2003-10-03 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-01 11:34 [RFC] add rtnl semaphore to linux-atm chas williams
2003-10-01 12:42 ` David S. Miller
2003-10-01 13:07 ` chas williams
2003-10-01 13:14 ` David S. Miller
2003-10-03 2:26 ` Mitchell Blank Jr
2003-10-03 13:58 ` David S. Miller [this message]
2003-10-03 21:45 ` Mitchell Blank Jr
2003-10-04 5:16 ` David S. Miller
2003-10-04 5:55 ` Mitchell Blank Jr
2003-10-04 6:56 ` Mitchell Blank Jr
2003-10-04 6:59 ` Mitchell Blank Jr
2003-10-04 12:50 ` chas williams
2003-10-04 19:42 ` Mitchell Blank Jr
2003-10-05 12:52 ` chas williams
2003-10-06 9:03 ` Mitchell Blank Jr
2003-10-06 14:46 ` chas williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031003065824.713627c6.davem@redhat.com \
--to=davem@redhat.com \
--cc=chas3@users.sourceforge.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=mitch@sfgoth.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).