netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: netdev@oss.sgi.com, bridge <bridge@osdl.org>,
	"David S.Miller" <davem@redhat.com>,
	Ben Greear <greearb@candelatech.com>,
	vlan@wanfear.com
Subject: Re: [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets
Date: Mon, 6 Oct 2003 13:19:16 -0700	[thread overview]
Message-ID: <20031006131916.6a7ba5c0.shemminger@osdl.org> (raw)
In-Reply-To: <200310062204.07230.bdschuym@pandora.be>

On Mon, 6 Oct 2003 22:04:07 +0200
Bart De Schuymer <bdschuym@pandora.be> wrote:

> Hi all,
> 
> The patch below does four trivial changes and one big change
> Trivial changes, these are all in br_netfilter.c:
> - check ar_pln==4 when giving bridged ARP packets to arptables
> - delete unnecessary if in br_nf_local_in
> - add more logging for the "Argh" message
> - add some brag-comments in the file head comment
> 
> Big change: let {ip,arp}tables see VLAN tagged {I,AR}P packets.
> This patch also makes an oops go away when locally generated packets
> are sent through something like br0.1000.
> 
> This is what the patch does:
> - add vlan_dev_hard_start_xmit_p, because br_netfilter.c needs to know
> the address of vlan_dev_hard_start_xmit(). When the local machine sends
> a packet through br0.1000, we need to allow filtering in LOCAL_OUT/FILTER
> on the bridge out port, so we need to be able to postpone the iptables
> filtering.

> Comments are welcome.
> If people could test this patch and give feedback, that would be great.
> 
> cheers,
> Bart


I can test the no VLAN case, but actual VLAN's are a little harder to setup.
How does this affect the ability to rmmod either vlan or bridge?

  reply	other threads:[~2003-10-06 20:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-06 20:04 [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets Bart De Schuymer
2003-10-06 20:19 ` Stephen Hemminger [this message]
2003-10-06 20:55   ` Bart De Schuymer
2003-10-06 20:24 ` Ben Greear
2003-10-06 20:58   ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Bart De Schuymer
2003-10-07 15:06 ` [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets David S. Miller
2003-10-07 19:12   ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables " Bart De Schuymer
2003-10-07 19:12     ` David S. Miller
2003-10-07 20:22     ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Stephen Hemminger
2003-10-07 15:52 ` [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031006131916.6a7ba5c0.shemminger@osdl.org \
    --to=shemminger@osdl.org \
    --cc=bdschuym@pandora.be \
    --cc=bridge@osdl.org \
    --cc=davem@redhat.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@oss.sgi.com \
    --cc=vlan@wanfear.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).