From: Bart De Schuymer <bdschuym@pandora.be>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev@oss.sgi.com, vlan@wanfear.com, bridge <bridge@osdl.org>,
Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets
Date: Mon, 6 Oct 2003 22:58:27 +0200 [thread overview]
Message-ID: <200310062258.27943.bdschuym@pandora.be> (raw)
In-Reply-To: <3F81CF75.5050802@candelatech.com>
On Monday 06 October 2003 22:24, Ben Greear wrote:
> Bart De Schuymer wrote:
> > - add some code in vlan_dev.c::vlan_dev_hard_start_xmit():
> > skb->protocol = __constant_htons(ETH_P_8021Q);
> > skb->mac.raw -= VLAN_HLEN;
> > skb->nh.raw -= VLAN_HLEN;
>
> I wonder if this is what was messing up the tcpdump packet capture
> as well?
A wrong Ethernet header pointer should probably do the trick.
> It would be fine with me if you un-conditionally exported the
> vlan hard-start-xmit pointer, but I don't feel strongly either way.
Me neither. I just let Dave decide in those cases :-)
cheers,
Bart
next prev parent reply other threads:[~2003-10-06 20:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 20:04 [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets Bart De Schuymer
2003-10-06 20:19 ` Stephen Hemminger
2003-10-06 20:55 ` Bart De Schuymer
2003-10-06 20:24 ` Ben Greear
2003-10-06 20:58 ` Bart De Schuymer [this message]
2003-10-07 15:06 ` David S. Miller
2003-10-07 19:12 ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables " Bart De Schuymer
2003-10-07 19:12 ` David S. Miller
2003-10-07 20:22 ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Stephen Hemminger
2003-10-07 15:52 ` [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200310062258.27943.bdschuym@pandora.be \
--to=bdschuym@pandora.be \
--cc=bridge@osdl.org \
--cc=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
--cc=vlan@wanfear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).