From: "David S. Miller" <davem@redhat.com>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: netdev@oss.sgi.com, bridge@osdl.org, greearb@candelatech.com,
vlan@wanfear.com, shemminger@osdl.org
Subject: Re: [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets
Date: Tue, 7 Oct 2003 08:06:40 -0700 [thread overview]
Message-ID: <20031007080640.50de4d45.davem@redhat.com> (raw)
In-Reply-To: <200310062204.07230.bdschuym@pandora.be>
On Mon, 6 Oct 2003 22:04:07 +0200
Bart De Schuymer <bdschuym@pandora.be> wrote:
> - unsigned long hh[16 / sizeof(unsigned long)];
> + unsigned char hh[18];
Maybe don't do this? It should be aligned on a 'long' boundry I
think.
The only real hard objection I have with the patch is the vlan xmit
routine pointer crap, just export the symbol.
Once you fix that I'll apply your patch as long as Stephen has no
objections.
next prev parent reply other threads:[~2003-10-07 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-06 20:04 [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets Bart De Schuymer
2003-10-06 20:19 ` Stephen Hemminger
2003-10-06 20:55 ` Bart De Schuymer
2003-10-06 20:24 ` Ben Greear
2003-10-06 20:58 ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Bart De Schuymer
2003-10-07 15:06 ` David S. Miller [this message]
2003-10-07 19:12 ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I,AR}P packets Bart De Schuymer
2003-10-07 19:12 ` David S. Miller
2003-10-07 20:22 ` [Bridge] Re: [PATCH/RFC] Let {ip, arp}tables "see" bridged VLAN tagged {I, AR}P packets Stephen Hemminger
2003-10-07 15:52 ` [PATCH/RFC] Let {ip,arp}tables "see" bridged VLAN tagged {I,AR}P packets Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031007080640.50de4d45.davem@redhat.com \
--to=davem@redhat.com \
--cc=bdschuym@pandora.be \
--cc=bridge@osdl.org \
--cc=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
--cc=vlan@wanfear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).