From: "David S. Miller" <davem@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: jt@hpl.hp.com, netdev@oss.sgi.com
Subject: Re: [PATCH] spinlock badness in last dongle changes.
Date: Tue, 7 Oct 2003 08:29:02 -0700 [thread overview]
Message-ID: <20031007082902.03dc16be.davem@redhat.com> (raw)
In-Reply-To: <20031006222631.1934f8e1.shemminger@osdl.org>
On Mon, 6 Oct 2003 22:26:31 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> A couple of locking problems happened when converted from using
> hashbin lock outside of irqueue. First, the lock was never initialized;
> Second, the lock was being unlocked after the hashbin was free.
>
> Since the hashbin of dongles should be empty (ie all dongle unregistered)
> don't really need locking there, so just warn if we find anything...
Applied, thanks Stephen.
Jean didn't express his opinion, but if he doesn't like the change
we can just put the fix he prefers on top.
next prev parent reply other threads:[~2003-10-07 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 5:26 [PATCH] spinlock badness in last dongle changes Stephen Hemminger
2003-10-07 15:29 ` David S. Miller [this message]
2003-10-08 2:03 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031007082902.03dc16be.davem@redhat.com \
--to=davem@redhat.com \
--cc=jt@hpl.hp.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).