* [PATCH] Fix warnings in defxx.c
@ 2003-10-07 17:55 Andi Kleen
2003-10-07 18:15 ` Maciej W. Rozycki
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2003-10-07 17:55 UTC (permalink / raw)
To: jgarzik, netdev
Fix harmless 64bit warnings in defxx.c
diff -u linux-2.5-cleanup/drivers/net/defxx.c-o linux-2.5-cleanup/drivers/net/defxx.c
--- linux-2.5-cleanup/drivers/net/defxx.c-o 2003-08-22 13:35:29.000000000 +0200
+++ linux-2.5-cleanup/drivers/net/defxx.c 2003-12-02 17:12:55.629162080 +0100
@@ -2664,8 +2664,8 @@
static void my_skb_align(struct sk_buff *skb, int n)
{
- u32 x=(u32)skb->data; /* We only want the low bits .. */
- u32 v;
+ unsigned long x=(unsigned long)skb->data;
+ unsigned long v;
v=(x+n-1)&~(n-1); /* Where we want to be */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix warnings in defxx.c
2003-10-07 17:55 [PATCH] Fix warnings in defxx.c Andi Kleen
@ 2003-10-07 18:15 ` Maciej W. Rozycki
0 siblings, 0 replies; 2+ messages in thread
From: Maciej W. Rozycki @ 2003-10-07 18:15 UTC (permalink / raw)
To: Andi Kleen; +Cc: jgarzik, netdev
On Tue, 7 Oct 2003, Andi Kleen wrote:
> Fix harmless 64bit warnings in defxx.c
>
> diff -u linux-2.5-cleanup/drivers/net/defxx.c-o linux-2.5-cleanup/drivers/net/defxx.c
> --- linux-2.5-cleanup/drivers/net/defxx.c-o 2003-08-22 13:35:29.000000000 +0200
> +++ linux-2.5-cleanup/drivers/net/defxx.c 2003-12-02 17:12:55.629162080 +0100
> @@ -2664,8 +2664,8 @@
>
> static void my_skb_align(struct sk_buff *skb, int n)
> {
> - u32 x=(u32)skb->data; /* We only want the low bits .. */
> - u32 v;
> + unsigned long x=(unsigned long)skb->data;
> + unsigned long v;
>
> v=(x+n-1)&~(n-1); /* Where we want to be */
Thanks for the fix. I have a 64-bit system to test the driver at the run
time (for both endiannesses, even), so in a long run I'm going to keep an
eye on such bits.
--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: macro@ds2.pg.gda.pl, PGP key available +
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-10-07 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-07 17:55 [PATCH] Fix warnings in defxx.c Andi Kleen
2003-10-07 18:15 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).