From: Andi Kleen <ak@muc.de>
To: ncorbic@sangoma.com
Cc: netdev@oss.sgi.com, davem@redhat.com
Subject: [PATCH] Fix 64bit bugs in dscc44.c
Date: Tue, 7 Oct 2003 19:59:53 +0200 [thread overview]
Message-ID: <20031007175953.GA1802@averell> (raw)
ioremap_nocache returns unsigned long, not u32. This makes a difference
on 64bit hosts.
-Andi
diff -u linux-2.5-cleanup/drivers/net/wan/dscc4.c-o linux-2.5-cleanup/drivers/net/wan/dscc4.c
--- linux-2.5-cleanup/drivers/net/wan/dscc4.c-o 2003-12-01 14:04:34.000000000 +0100
+++ linux-2.5-cleanup/drivers/net/wan/dscc4.c 2003-12-02 16:55:14.298508864 +0100
@@ -980,7 +980,7 @@
*
* This code doesn't need to be efficient. Keep It Simple
*/
-static void dscc4_pci_reset(struct pci_dev *pdev, u32 ioaddr)
+static void dscc4_pci_reset(struct pci_dev *pdev, unsigned long ioaddr)
{
int i;
@@ -1461,7 +1461,8 @@
struct dscc4_dev_priv *root = token;
struct dscc4_pci_priv *priv;
struct net_device *dev;
- u32 ioaddr, state;
+ unsigned long ioaddr;
+ u32 state;
unsigned long flags;
int i, handled = 1;
@@ -1613,7 +1614,7 @@
goto try;
}
if (state & Xpr) {
- u32 scc_addr, ring;
+ unsigned long scc_addr, ring;
int i;
/*
@@ -1954,7 +1955,7 @@
{
struct dscc4_pci_priv *ppriv;
struct dscc4_dev_priv *root;
- u32 ioaddr;
+ unsigned long ioaddr;
int i;
ppriv = pci_get_drvdata(pdev);
next reply other threads:[~2003-10-07 17:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 17:59 Andi Kleen [this message]
2003-10-07 21:48 ` [PATCH] Fix 64bit bugs in dscc4.c Francois Romieu
2003-10-08 15:42 ` [PATCH] Fix 64bit bugs in dscc44.c David S. Miller
2003-10-08 15:55 ` Andi Kleen
2003-10-08 16:01 ` David S. Miller
2003-10-08 16:08 ` Andi Kleen
2003-10-08 16:11 ` [PATCH] Fix 64bit bugs in dscc44.c II Andi Kleen
2003-10-08 16:10 ` David S. Miller
2003-10-08 16:33 ` Andi Kleen
2003-10-08 16:31 ` David S. Miller
2003-10-08 17:00 ` Andi Kleen
2003-10-08 16:59 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031007175953.GA1802@averell \
--to=ak@muc.de \
--cc=davem@redhat.com \
--cc=ncorbic@sangoma.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).