From: "David S. Miller" <davem@redhat.com>
To: Tobias DiPasquale <toby@cbcg.net>
Cc: jgarzik@pobox.com, netdev@oss.sgi.com, linux-net@vger.kernel.org,
linux-kernel@vger.kernel.org, coreteam@netfilter.org,
netfilter@lists.netfilter.org, akpm@zip.com.au,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@intercode.com.au, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] kfree_skb() bug in 2.4.22
Date: Wed, 8 Oct 2003 07:11:59 -0700 [thread overview]
Message-ID: <20031008071159.586c5d3c.davem@redhat.com> (raw)
In-Reply-To: <1065622303.1512.41.camel@localhost>
On Wed, 08 Oct 2003 10:11:43 -0400
Tobias DiPasquale <toby@cbcg.net> wrote:
> Well, I certainly have done that already ;-) But I have checked kfree()
> and vfree() and they have a sanity check for NULL before processing, as
> well as those are also the well-known semantics for the userspace free()
> call.
So what? Those are totally different APIs and they in no way determine
how other interfaces should behave.
Passing NULL pointers around usually indicates poorly designed
software anyways (unless the NULL pointer is being returned by
a routine to indicate an allocation failure).
This isn't even worth discussing anymore.
prev parent reply other threads:[~2003-10-08 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 12:44 [PATCH] kfree_skb() bug in 2.4.22 Tobias DiPasquale
2003-10-08 13:09 ` Jeff Garzik
2003-10-08 13:47 ` David S. Miller
2003-10-10 12:53 ` Ingo Oeser
2003-10-10 13:00 ` David S. Miller
2003-10-10 15:43 ` Ingo Oeser
2003-10-10 16:57 ` Dan Kegel
2003-10-08 14:11 ` Tobias DiPasquale
2003-10-08 14:11 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031008071159.586c5d3c.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@zip.com.au \
--cc=coreteam@netfilter.org \
--cc=jgarzik@pobox.com \
--cc=jmorris@intercode.com.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=netfilter@lists.netfilter.org \
--cc=pekkas@netcore.fi \
--cc=toby@cbcg.net \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).