From: "David S. Miller" <davem@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: ak@muc.de, ncorbic@sangoma.com, netdev@oss.sgi.com
Subject: Re: [PATCH] Fix 64bit bugs in dscc44.c
Date: Wed, 8 Oct 2003 09:01:32 -0700 [thread overview]
Message-ID: <20031008090132.2b58c067.davem@redhat.com> (raw)
In-Reply-To: <20031008155548.GB16937@wotan.suse.de>
On Wed, 8 Oct 2003 17:55:48 +0200
Andi Kleen <ak@suse.de> wrote:
> I agree it would have been better to write:
> "ioremap and ioremap_nocache return pointers and that should
> be stored in a pointer variable. However when you really want
> to store them in a integer variable for unknown reasons always
> use unsigned long, not u32 or int"
>
> However that was just too long, so I didn't write it.
Don't replace one error with a new warning, just add the cast
to the ioremap() call or something like that.
next prev parent reply other threads:[~2003-10-08 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 17:59 [PATCH] Fix 64bit bugs in dscc44.c Andi Kleen
2003-10-07 21:48 ` [PATCH] Fix 64bit bugs in dscc4.c Francois Romieu
2003-10-08 15:42 ` [PATCH] Fix 64bit bugs in dscc44.c David S. Miller
2003-10-08 15:55 ` Andi Kleen
2003-10-08 16:01 ` David S. Miller [this message]
2003-10-08 16:08 ` Andi Kleen
2003-10-08 16:11 ` [PATCH] Fix 64bit bugs in dscc44.c II Andi Kleen
2003-10-08 16:10 ` David S. Miller
2003-10-08 16:33 ` Andi Kleen
2003-10-08 16:31 ` David S. Miller
2003-10-08 17:00 ` Andi Kleen
2003-10-08 16:59 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031008090132.2b58c067.davem@redhat.com \
--to=davem@redhat.com \
--cc=ak@muc.de \
--cc=ak@suse.de \
--cc=ncorbic@sangoma.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).