netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: ak@suse.de, modica@sgi.com, johnip@sgi.com, netdev@oss.sgi.com,
	jgarzik@pobox.com, jes@sgi.com
Subject: Re: Tigon3 5701 PCI-X recv performance problem
Date: Wed, 8 Oct 2003 13:32:48 -0700	[thread overview]
Message-ID: <20031008133248.1583ddcf.davem@redhat.com> (raw)
In-Reply-To: <20031008203306.GB15611@oldwotan.suse.de>

On Wed, 8 Oct 2003 22:33:06 +0200
Andi Kleen <ak@suse.de> wrote:

> Well, this thread was about the tigon3 and I don't see that as an el cheapo
> card. If SGI uses it on the Altix I guess they want it to perform well 
> with many CPUs.

It's one of the oldest variants of the tg3 chip and it's full
of hardware bugs when used in PCI-X.

> I personally think it's better to just use slab to implement it,
> allocating pages doesn't seem to have any advantages to me.

The page chunk allocator is meant to make it easier to put the
non-header parts in the frag list of the SKB, see?  It means we
don't need to do anything special in the networking, all the
receive paths handle frag'd RX packets properly.

We can't take pages SLAB is using and attach them to the fraglist
of the SKB, kfree_skb() is going to try and put_page() on them.

If we used slab, we'd need to do something like:

1) skb->h.raw or whatever have special meaning and point to
   different buffers.

2) There's a skb->data2 or something like that.

Both are a lot of work compared to my suggestion.

  reply	other threads:[~2003-10-08 20:32 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-08 17:12 Tigon3 5701 PCI-X recv performance problem John Partridge
2003-10-08 17:10 ` David S. Miller
2003-10-08 17:52   ` John Partridge
2003-10-08 18:26     ` David S. Miller
2003-10-08 19:02       ` John Partridge
2003-10-08 19:11         ` Steve Modica
2003-10-08 19:15           ` David S. Miller
2003-10-08 18:21   ` Steve Modica
2003-10-08 18:29     ` David S. Miller
2003-10-08 18:37     ` Andi Kleen
2003-10-08 19:22       ` David S. Miller
2003-10-08 20:22         ` Andi Kleen
2003-10-08 20:24           ` David S. Miller
2003-10-08 20:33             ` Andi Kleen
2003-10-08 20:32               ` David S. Miller [this message]
2003-10-08 20:46                 ` Andi Kleen
2003-10-08 20:50                   ` David S. Miller
2003-10-10 19:05           ` Steve Modica
2003-10-10 19:20             ` Andi Kleen
2003-10-11 13:17               ` Steve Modica
2003-10-11 13:19                 ` Andi Kleen
2003-10-11 17:50                   ` David S. Miller
2003-10-13 19:53                     ` John Partridge
2003-10-13 19:51                       ` David S. Miller
2003-10-14 16:49                     ` John Partridge
2003-10-14 16:53                       ` David S. Miller
2003-11-11  1:24                         ` John Partridge
2003-11-11  2:29                           ` David S. Miller
2003-11-11 20:04                             ` John Partridge
2003-11-11 20:24                               ` David S. Miller
2003-11-11 21:26                                 ` John Partridge
2003-11-11 21:32                                   ` Jeff Garzik
2003-12-03 22:11                                     ` John Partridge
2003-11-11 21:39                                 ` John Partridge
2003-11-11 23:09                                   ` David S. Miller
2003-11-11 23:53                                   ` Andi Kleen
2003-11-12  1:46                                     ` John Partridge
2003-11-12  6:19                                       ` Andi Kleen
2003-11-12  7:05                                         ` Jeff Garzik
2003-11-12 15:32                                           ` John Partridge
2003-11-12 15:43                                             ` Christoph Hellwig
2003-11-11 20:25                               ` David S. Miller
2003-11-11 20:57                                 ` Jeff Garzik
2003-10-14 18:47                   ` John Partridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031008133248.1583ddcf.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=ak@suse.de \
    --cc=jes@sgi.com \
    --cc=jgarzik@pobox.com \
    --cc=johnip@sgi.com \
    --cc=modica@sgi.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).