From: Andi Kleen <ak@suse.de>
To: Andi Kleen <ak@suse.de>
Cc: "David S. Miller" <davem@redhat.com>,
ak@muc.de, ncorbic@sangoma.com, netdev@oss.sgi.com
Subject: Re: [PATCH] Fix 64bit bugs in dscc44.c II
Date: Wed, 8 Oct 2003 18:11:49 +0200 [thread overview]
Message-ID: <20031008161149.GA8134@wotan.suse.de> (raw)
In-Reply-To: <20031008160859.GD16937@wotan.suse.de>
> I don't particularly care about the warning, just that it will
> obviously crash on a 64bit box when loaded. My change was the simplest
> possible fix for that. I have no plans to rewrite this driver
> or something.
BTW my change fixed the warning.
It's somewhat ugly to store pointers in unsigned long I agree,
but it's hard to blame the driver author when this cruft is even
enshrined in fundamental interfaces (__get_free_pages/__free_pages)
-Andi
next prev parent reply other threads:[~2003-10-08 16:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 17:59 [PATCH] Fix 64bit bugs in dscc44.c Andi Kleen
2003-10-07 21:48 ` [PATCH] Fix 64bit bugs in dscc4.c Francois Romieu
2003-10-08 15:42 ` [PATCH] Fix 64bit bugs in dscc44.c David S. Miller
2003-10-08 15:55 ` Andi Kleen
2003-10-08 16:01 ` David S. Miller
2003-10-08 16:08 ` Andi Kleen
2003-10-08 16:11 ` Andi Kleen [this message]
2003-10-08 16:10 ` [PATCH] Fix 64bit bugs in dscc44.c II David S. Miller
2003-10-08 16:33 ` Andi Kleen
2003-10-08 16:31 ` David S. Miller
2003-10-08 17:00 ` Andi Kleen
2003-10-08 16:59 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031008161149.GA8134@wotan.suse.de \
--to=ak@suse.de \
--cc=ak@muc.de \
--cc=davem@redhat.com \
--cc=ncorbic@sangoma.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).