From: "David S. Miller" <davem@redhat.com>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: netdev@oss.sgi.com, dmerillat@sequiam.com
Subject: Re: [RFT] Re: Fw: Nasty Oops in 2.6.0-test6 bind/SO_REUSEADDR
Date: Thu, 9 Oct 2003 21:14:37 -0700 [thread overview]
Message-ID: <20031009211437.2cf87a4f.davem@redhat.com> (raw)
In-Reply-To: <20031010032244.GB8365@conectiva.com.br>
Even if they make the OOPS go away, all of these patches are
not correct.
You have to consider the timewait sockets just like established
sockets in the bind conflict test.
Therefore in the most inner part of this chain of if's you need
to have something like:
u32 rcv_saddr;
if (sk->sk_state == TCP_TIME_WAIT) {
struct tcp_tw_bucket *tw = tcptw_sk(sk2);
rcv_saddr = tw->tw_rcv_saddr;
} else {
struct inet_sock *inet = inet_sk(sk2);
rcv_saddr = inet->rcv_saddr;
}
if (!rcv_saddr || !sk->rcv_saddr ||
sk->rcv_saddr == rcv_saddr)
... blah blah blah ...
next prev parent reply other threads:[~2003-10-10 4:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-08 20:33 Fw: Nasty Oops in 2.6.0-test6 bind/SO_REUSEADDR David S. Miller
2003-10-09 17:03 ` Dan Merillat
2003-10-10 2:36 ` Arnaldo Carvalho de Melo
2003-10-10 3:22 ` [RFT] " Arnaldo Carvalho de Melo
2003-10-10 4:14 ` David S. Miller [this message]
2003-10-10 15:40 ` Arnaldo Carvalho de Melo
2003-10-11 19:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031009211437.2cf87a4f.davem@redhat.com \
--to=davem@redhat.com \
--cc=acme@conectiva.com.br \
--cc=dmerillat@sequiam.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).