From: "David S. Miller" <davem@redhat.com>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] fixing the cases where tcp_tw_bucket was accessed as a sock
Date: Mon, 13 Oct 2003 12:49:30 -0700 [thread overview]
Message-ID: <20031013124930.0e75a325.davem@redhat.com> (raw)
In-Reply-To: <20031012131344.GH16182@conectiva.com.br>
On Sun, 12 Oct 2003 10:13:44 -0300
Arnaldo Carvalho de Melo <acme@conectiva.com.br> wrote:
> The WARN_ON is just to be paranoid for a while, I should have done
> that a loooong time ago :-\
I appreciate the intentions here but the resulting code is
really a mess. We have this thing now in in.h called
"inet_something()" that tests TCP state, and then we have
something similar for ipv6 in addrconf.c :-)
Let's do one thing at a time. First, fix the original bug
in tcp_ipv4.c by just putting your inet_rcv_saddr() shorthand
right there in tcp_ipv4.c and name it tcp4_rcv_saddr() or
something like that.
Then we can move onto the rest of the changes and try to find
a common place for the helper routines.
See what happens when you try to do too many things at one
time :-)
next prev parent reply other threads:[~2003-10-13 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-12 13:13 [PATCH] fixing the cases where tcp_tw_bucket was accessed as a sock Arnaldo Carvalho de Melo
2003-10-13 19:49 ` David S. Miller [this message]
2003-10-15 11:36 ` Arnaldo Carvalho de Melo
2003-10-16 5:10 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031013124930.0e75a325.davem@redhat.com \
--to=davem@redhat.com \
--cc=acme@conectiva.com.br \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).