From: "David S. Miller" <davem@redhat.com>
To: Shirley Ma <mashirle@us.ibm.com>
Cc: kuznet@ms2.inr.ac.ru, netdev@oss.sgi.com
Subject: Re: [PATCH]Implementation for IPv6 MIB:ipv6InterfaceTable
Date: Tue, 14 Oct 2003 15:24:41 -0700 [thread overview]
Message-ID: <20031014152441.1be6b336.davem@redhat.com> (raw)
In-Reply-To: <200310141032.23998.mashirle@us.ibm.com>
On Tue, 14 Oct 2003 10:32:23 -0700
Shirley Ma <mashirle@us.ibm.com> wrote:
> +#ifdef CONFIG_SYSCTL
> +#include <linux/sysctl.h>
> +#endif
Please don't add ifdefs around header includes like this if
you can avoid it.
> +void inet6_ifinfo_notify(int event, struct inet6_dev *idev);
...
> +extern int ndisc_ifinfo_sysctl_change(ctl_table *ctl, int write, struct file
...
> +extern void inet6_ifinfo_notify(int event, struct inet6_dev *idev);
...
These belong in header files, not scattered around in *.c files.
Thanks.
next prev parent reply other threads:[~2003-10-14 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-14 17:32 [PATCH]Implementation for IPv6 MIB:ipv6InterfaceTable Shirley Ma
2003-10-14 22:24 ` David S. Miller [this message]
2003-10-20 23:00 ` [PATCH] New Patch Implementation " Shirley Ma
2003-10-20 23:43 ` Shirley Ma
2003-10-21 4:04 ` David S. Miller
2004-01-14 22:48 ` Shirley Ma
2004-01-15 8:55 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031014152441.1be6b336.davem@redhat.com \
--to=davem@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=mashirle@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).