From: Andi Kleen <ak@colin2.muc.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andi Kleen <ak@muc.de>, netdev@oss.sgi.com
Subject: Re: [PATCH] Fix 64bit warnings in rtl8139too
Date: 14 Oct 2003 21:49:14 +0200
Date: Tue, 14 Oct 2003 21:49:14 +0200 [thread overview]
Message-ID: <20031014194914.GA58843@colin2.muc.de> (raw)
In-Reply-To: <3F8C3CB0.9090502@pobox.com>
On Tue, Oct 14, 2003 at 02:13:04PM -0400, Jeff Garzik wrote:
> Andi Kleen wrote:
> >Fix a harmless 64bit pointer/integer mismatch warning in 8139too.
> >
> >diff -u linux-2.5-cleanup/drivers/net/8139too.c-o
> >linux-2.5-cleanup/drivers/net/8139too.c
> >--- linux-2.5-cleanup/drivers/net/8139too.c-o 2003-09-08
> >00:02:03.000000000 +0200
> >+++ linux-2.5-cleanup/drivers/net/8139too.c 2003-12-02
> >17:13:24.634752560 +0100
> >@@ -746,7 +746,8 @@
> > u8 tmp8;
> > int rc;
> > unsigned int i;
> >- u32 pio_start, pio_end, pio_flags, pio_len;
> >+ unsigned long pio_start;
> >+ u32 pio_end, pio_flags, pio_len;
> > unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
> > u32 version;
>
>
> Why not just make this look like mmio_*?
No problems, feel free to do that.
I just did the minimal change to fix the warning.
-Andi
prev parent reply other threads:[~2003-10-14 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 17:56 [PATCH] Fix 64bit warnings in rtl8139too Andi Kleen
2003-10-14 18:13 ` Jeff Garzik
2003-10-14 19:49 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031014194914.GA58843@colin2.muc.de \
--to=ak@colin2.muc.de \
--cc=ak@muc.de \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).