From: "David S. Miller" <davem@redhat.com>
To: "Randy.Dunlap" <rddunlap@osdl.org.sgi.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] init_netdev missing locking
Date: Wed, 15 Oct 2003 22:33:18 -0700 [thread overview]
Message-ID: <20031015223318.597494ed.davem@redhat.com> (raw)
In-Reply-To: <20031015110520.0206e327.rddunlap@osdl.org>
On Wed, 15 Oct 2003 11:05:20 -0700
"Randy.Dunlap" <rddunlap@osdl.org> wrote:
> It looks like the call to dev_alloc_name() in init_netdev()
> isn't protected by the required locking.
> This patch adds rtnl_lock/unlock around the call to dev_alloc_name().
>
> Comments? or please apply.
Your fix is correct, so I've applied it. Stephen is working to
deprecate the one thing that uses this function (init_etherdev()).
Please in the future properly root your patch, I had to fix this
one up before my automated scripts would eat it :)
prev parent reply other threads:[~2003-10-16 5:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-15 18:05 [PATCH] init_netdev missing locking Randy.Dunlap
2003-10-16 5:33 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031015223318.597494ed.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=rddunlap@osdl.org.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).