From: "David S. Miller" <davem@redhat.com>
To: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH?] Fix sniffing of ARP replies
Date: Thu, 16 Oct 2003 15:21:36 -0700 [thread overview]
Message-ID: <20031016152136.50e2a389.davem@redhat.com> (raw)
In-Reply-To: <32A9D366A0B@vcnet.vc.cvut.cz>
On Thu, 16 Oct 2003 12:07:23 +0200
"Petr Vandrovec" <VANDROVE@vc.cvut.cz> wrote:
> It behaves same way it behaved. But recently you renamed packet_type.data
> to packet_type.af_packet_priv, saying that af_packet_priv should be used
> only by AF_PACKET code, by nobody else. So I trusted you, removed
> packet_type.data (and packet_type.af_packet_priv) references from the
> code - and things stopped working, as with af_packet_priv==NULL ARP
> replies are not delivered to the registered packet_type callback, as
> these packets match skb->sk == pt->af_packet_priv for af_packet_priv == NULL.
vmware was trying to influence the behavior of input packet
delivery by setting ->data in a way which was never defined.
That facility existed and continues to exist for the sake
of AF_PACKET solely, what vmware was doing just happened to work.
next prev parent reply other threads:[~2003-10-16 22:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-16 10:07 [PATCH?] Fix sniffing of ARP replies Petr Vandrovec
2003-10-16 22:21 ` David S. Miller [this message]
2003-10-16 22:41 ` Joe Perches
2003-10-16 22:45 ` David S. Miller
2003-10-16 23:48 ` Petr Vandrovec
2003-10-17 6:55 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2003-10-15 17:11 Petr Vandrovec
2003-10-16 3:47 ` David S. Miller
2003-10-17 7:10 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031016152136.50e2a389.davem@redhat.com \
--to=davem@redhat.com \
--cc=VANDROVE@vc.cvut.cz \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).