From: "David S. Miller" <davem@redhat.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] Prevent "eth0: driver changed get_stats after register" lying
Date: Sun, 19 Oct 2003 00:06:46 -0700 [thread overview]
Message-ID: <20031019000646.19f39f51.davem@redhat.com> (raw)
In-Reply-To: <20031018214622.B25375@flint.arm.linux.org.uk>
On Sat, 18 Oct 2003 21:46:22 +0100
Russell King <rmk@arm.linux.org.uk> wrote:
> We set "dev->last_stats" after we have registered the class device.
> During class device registration, we trigger the hotplug scripts,
> which can in turn bring up the interface. This in turn checks to
> see if "dev->last_stats == dev->get_stats", and, since we haven't
> set dev->last_stats yet, we complain.
>
> Here is a patch against 2.6.0-test8 which moves the initialisation
> of last_stats such that we avoid the race.
Looks ok, thanks Russell.
prev parent reply other threads:[~2003-10-19 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-18 20:46 [PATCH] Prevent "eth0: driver changed get_stats after register" lying Russell King
2003-10-18 20:47 ` Russell King
2003-10-19 7:06 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031019000646.19f39f51.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).