From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "Noah J. Misch" <noah@caltech.edu>
Cc: rddunlap@osdl.org, linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] Make LLC2 compile with PROC_FS=n
Date: Mon, 20 Oct 2003 04:44:28 -0300 [thread overview]
Message-ID: <20031020074428.GA26494@conectiva.com.br> (raw)
In-Reply-To: <Pine.GSO.4.58.0310171452540.13905@blinky>
Em Sun, Oct 19, 2003 at 10:03:52PM -0700, Noah J. Misch escreveu:
> Hello Arnaldo,
>
> This patch allows the LLC2 code to link properly when CONFIG_PROC_FS=n. The
> problem was that the Makefile only built llc_proc.c when PROC_FS=y/m, but
> af_llc.c called functions in that file in all cases. The log details how I
> fixed this.
>
> I think this is the best fix, but of course there are a number of less intrusive
> fixes, including (I think) one as simple as making llc_proc.c always compile.
> This one does apply cleanly to linux-2.5 BK as of 0400 UTC 10/20/2003 and passes
> allyesconfig and (allyesconfig - PROC_FS) compiles on i386.
>
> Please let me know if I should supply you with further information.
I'm OK with this patch.
- Arnaldo
next prev parent reply other threads:[~2003-10-20 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-20 5:03 [PATCH] Make LLC2 compile with PROC_FS=n Noah J. Misch
2003-10-20 7:44 ` Arnaldo Carvalho de Melo [this message]
2003-10-20 17:16 ` Stephen Hemminger
2003-10-21 5:32 ` David S. Miller
2003-10-21 11:13 ` Noah J. Misch
2003-10-22 21:18 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031020074428.GA26494@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=noah@caltech.edu \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).