From: "David S. Miller" <davem@redhat.com>
To: Tomas Szepe <szepe@pinerecords.com>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com, grof@dragon.cz
Subject: Re: possible bug in tcp_input.c
Date: Fri, 24 Oct 2003 19:30:34 -0700 [thread overview]
Message-ID: <20031024193034.30f1caed.davem@redhat.com> (raw)
In-Reply-To: <20031024162959.GB11154@louise.pinerecords.com>
On Fri, 24 Oct 2003 18:29:59 +0200
Tomas Szepe <szepe@pinerecords.com> wrote:
> /* tcp_input.c, line 1138 */
> static inline int tcp_head_timedout(struct sock *sk, struct tcp_opt *tp)
> {
> return tp->packets_out && tcp_skb_timedout(tp, skb_peek(&sk->write_queue));
> }
>
> The passed NULL (and yes, this is where we are getting one) is dereferenced
> immediately in:
>
> /* tcp_input.c, line 1133 */
> static inline int tcp_skb_timedout(struct tcp_opt *tp, struct sk_buff *skb)
> {
> return (tcp_time_stamp - TCP_SKB_CB(skb)->when > tp->rto);
> }
If tp->packets_out is non-zero (which by definition it is
in your case else the right hand side of the "&&" would not be
evaluated) then we _MUST_ have some packets in sk->write_queue.
Something is being fiercely corrupted. Probably some piece of
netfilter is freeing up an SKB one too many times thus corrupting
the TCP write queue list pointers.
next prev parent reply other threads:[~2003-10-25 2:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-24 16:29 possible bug in tcp_input.c Tomas Szepe
2003-10-25 2:30 ` David S. Miller [this message]
2003-10-25 9:12 ` Tomas Szepe
2003-10-26 6:55 ` Tomas Szepe
2003-10-27 6:33 ` David S. Miller
[not found] <20031024162959.GB11154@louise.pinerecords.com.suse.lists.linux.kernel>
2003-10-24 17:57 ` Andi Kleen
2003-11-18 13:58 ` Tomas Szepe
2003-11-18 14:01 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031024193034.30f1caed.davem@redhat.com \
--to=davem@redhat.com \
--cc=grof@dragon.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=szepe@pinerecords.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).