From: "David S. Miller" <davem@redhat.com>
To: Tomas Szepe <szepe@pinerecords.com>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com, grof@dragon.cz,
volf@dragon.cz
Subject: Re: possible bug in tcp_input.c
Date: Sun, 26 Oct 2003 22:33:18 -0800 [thread overview]
Message-ID: <20031026223318.41917bb0.davem@redhat.com> (raw)
In-Reply-To: <20031026065519.GC28035@louise.pinerecords.com>
On Sun, 26 Oct 2003 07:55:19 +0100
Tomas Szepe <szepe@pinerecords.com> wrote:
> Dave, we've been thinking about this some more and have concluded
> that since the problem is a relatively non-fatal one, the kernel
> should just print out an "assertion failed" error similar to the
> one in tcp_input.c, line 1323 [BUG_TRAP(cnt <= tp->packets_out);]
> and maybe fix things up a little rather than oops on a NULL pointer
> dereference; The state in question, although invalid, is possible
> and should IMHO be checked for as in all the other "if (skb != NULL)
> ..." places).
If this condition triggers, the lists are corrupt and the kernel
should not try to access this socket in any way whatsoever
past this point.
Therefore it should OOPS, which is exactly what it does now.
A BUG_ON() is an equivalent response as far as I am concerned,
it has the same exact result, and the backtrace shows where the
problem is occuring.
next prev parent reply other threads:[~2003-10-27 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-24 16:29 possible bug in tcp_input.c Tomas Szepe
2003-10-25 2:30 ` David S. Miller
2003-10-25 9:12 ` Tomas Szepe
2003-10-26 6:55 ` Tomas Szepe
2003-10-27 6:33 ` David S. Miller [this message]
[not found] <20031024162959.GB11154@louise.pinerecords.com.suse.lists.linux.kernel>
2003-10-24 17:57 ` Andi Kleen
2003-11-18 13:58 ` Tomas Szepe
2003-11-18 14:01 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031026223318.41917bb0.davem@redhat.com \
--to=davem@redhat.com \
--cc=grof@dragon.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=szepe@pinerecords.com \
--cc=volf@dragon.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).