From: "David S. Miller" <davem@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: akpm@osdl.org, Andries.Brouwer@cwi.nl,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
kuznet@ms2.inr.ac.ru
Subject: Re: Linux 2.6.0-test9
Date: Sun, 26 Oct 2003 22:43:58 -0800 [thread overview]
Message-ID: <20031026224358.233e6d1a.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0310261623000.3157-100000@home.osdl.org>
On Sun, 26 Oct 2003 16:28:11 -0800 (PST)
Linus Torvalds <torvalds@osdl.org> wrote:
> But reverting the change is clearly the "safer" thing to do, I just worry
> that Alexey might have had a real reason for tryign to avoid the EINTR in
> the first place (for non-URG data).
I'd like to hear something from Alexey first.
The problem we were trying to deal with was that when data
is available to read a lot of people were complaining that
we return -EINTR and no other system does this.
This is heavily inconsistent with how we handle every other
type of socket error. In all other cases, a read() when data
is available will succeed until the very last byte is sucked
out of the socket, then any subsequent read() call after the
queue is emptied will return the error.
But I am starting to see that URG is different. It is not like
other socket errors that halt the socket and make no new data
arrive after it happens. Rather, URG can happen just about anywhere
and more data can continue to flow into the socket buffers.
In fact, this means that our change can result in an application
can never see the error if data continues to arrive faster than
the application can pull it out, see?
Alexey, I think we did not understand this case fully when making this
change.
next prev parent reply other threads:[~2003-10-27 6:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-26 19:40 Linux 2.6.0-test9 Andries.Brouwer
2003-10-27 0:01 ` Andrew Morton
2003-10-27 0:21 ` Linus Torvalds
2003-10-27 0:28 ` Linus Torvalds
2003-10-27 6:43 ` David S. Miller [this message]
2003-10-27 19:54 ` kuznet
2003-10-27 19:36 ` kuznet
2003-10-28 0:42 ` Tommy Christensen
2003-10-28 18:25 ` kuznet
-- strict thread matches above, loose matches on Subject: below --
2003-10-27 1:48 Andries.Brouwer
2003-10-27 2:10 ` Linus Torvalds
2003-10-27 9:40 ` David S. Miller
2003-10-27 9:47 Mikael Pettersson
2003-10-27 10:58 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031026224358.233e6d1a.davem@redhat.com \
--to=davem@redhat.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).