From: "David S. Miller" <davem@redhat.com>
To: Andi Kleen <ak@muc.de>
Cc: simon.roscic@chello.at, linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [2.6.0-test8/9] ethertap oops
Date: Sun, 26 Oct 2003 23:48:28 -0800 [thread overview]
Message-ID: <20031026234828.2cb1f746.davem@redhat.com> (raw)
In-Reply-To: <m3ekwz7h3z.fsf@averell.firstfloor.org>
On Sun, 26 Oct 2003 23:45:52 +0100
Andi Kleen <ak@muc.de> wrote:
> diff -u linux-2.6.0test7mm1-averell/drivers/net/ethertap.c-o linux-2.6.0test7mm1-averell/drivers/net/ethertap.c
> --- linux-2.6.0test7mm1-averell/drivers/net/ethertap.c-o 2003-09-11 04:12:33.000000000 +0200
> +++ linux-2.6.0test7mm1-averell/drivers/net/ethertap.c 2003-10-26 23:41:17.000000000 +0100
This part looks good, applied.
> diff -u linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c-o linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c
> --- linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c-o 2003-10-09 00:29:02.000000000 +0200
> +++ linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c 2003-10-26 23:42:44.000000000 +0100
> @@ -777,6 +777,7 @@
> if (input)
> nlk_sk(sk)->data_ready = input;
>
> + sk->sk_protocol = unit;
> netlink_insert(sk, 0);
> return sk;
> }
This part is not needed, netlink_create() does this for us :-)
Thanks Andi.
next prev parent reply other threads:[~2003-10-27 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <L1fo.3gb.9@gated-at.bofh.it>
2003-10-26 22:45 ` [2.6.0-test8/9] ethertap oops Andi Kleen
2003-10-27 7:48 ` David S. Miller [this message]
2003-10-27 12:26 ` Andi Kleen
[not found] ` <20031027122635.GB16013@wotan.suse.de>
2003-10-27 12:22 ` David S. Miller
2003-10-27 17:40 ` Simon Roscic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031026234828.2cb1f746.davem@redhat.com \
--to=davem@redhat.com \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=simon.roscic@chello.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).