From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: davem@redhat.com
Cc: netdev@oss.sgi.com, niteowl@austin.rr.com, pekkas@netcore.fi,
yoshfuji@linux-ipv6.org
Subject: Re: bugs in net/ipv6/mcast.c (fwd)
Date: Mon, 27 Oct 2003 11:07:10 +0900 (JST) [thread overview]
Message-ID: <20031027.110710.54972254.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0310252226470.12162-100000@netcore.fi>
In article <Pine.LNX.4.44.0310252226470.12162-100000@netcore.fi> (at Sat, 25 Oct 2003 22:27:27 +0300 (EEST)), Pekka Savola <pekkas@netcore.fi> says:
> Probably fixed already, but just in case...
Not yet in the bk tree.
> Hi. In the latest linux-2.6.0-test8 source there are 2 bugs in
> net/ipv6/mcast.c
> In function inet6_mc_check() the if statements on lines 607 and 609 have
> extra semicolons that will cause the code to fail.
>
> if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
> rv = 0;
> if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
> rv = 0;
Exactly. Patch follows.
===== net/ipv6/mcast.c 1.39 vs edited =====
--- 1.39/net/ipv6/mcast.c Fri Oct 17 17:05:20 2003
+++ edited/net/ipv6/mcast.c Mon Oct 27 11:01:27 2003
@@ -604,9 +604,9 @@
if (ipv6_addr_cmp(&psl->sl_addr[i], src_addr) == 0)
break;
}
- if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count);
+ if (mc->sfmode == MCAST_INCLUDE && i >= psl->sl_count)
rv = 0;
- if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count);
+ if (mc->sfmode == MCAST_EXCLUDE && i < psl->sl_count)
rv = 0;
}
read_unlock(&ipv6_sk_mc_lock);
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
next prev parent reply other threads:[~2003-10-27 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-25 19:27 bugs in net/ipv6/mcast.c (fwd) Pekka Savola
2003-10-27 2:07 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2003-10-27 8:02 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031027.110710.54972254.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=niteowl@austin.rr.com \
--cc=pekkas@netcore.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).